Skip to content

[HOLD for payment 2024-07-24] [Free trial] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends #43671

Closed

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 13, 2024
  2. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collecton Jun 13, 2024
  4. sakluger commented on Jun 14, 2024

    @sakluger
    Contributor

    Sounds like this will be handled internally - I asked @MitchExpensify to confirm.

  5. added
    InternalRequires API changes or must be handled by Expensify staff
    on Jun 14, 2024
  6. trjExpensify commented on Jun 18, 2024

    @trjExpensify
    Contributor

    Hm, this is a frontend issue isn't it?

  7. fabioh8010 commented on Jun 18, 2024

    @fabioh8010
    Contributor

    @trjExpensify Yes, it's frontend issue

  8. removed
    InternalRequires API changes or must be handled by Expensify staff
    on Jun 18, 2024
  9. 30 remaining items

  10. changed the title [-][Free trial] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends[/-] [+][HOLD for payment 2024-07-24] [Free trial] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends[/+] on Jul 17, 2024
  11. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-24. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rojiphil] The PR that introduced the bug has been identified. Link to the PR:
    • [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rojiphil] Determine if we should create a regression test for this bug.
    • [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. sakluger commented on Jul 23, 2024

    @sakluger
    Contributor

    Summarizing payment on this issue:

    Contributor: @pac-guerreiro - no payment required (Contractor)
    Contributor+: @rojiphil $250, sent offer via Upwork: https://www.upwork.com/nx/wm/offer/103240375

  15. rojiphil commented on Jul 24, 2024

    @rojiphil
    Contributor

    sent offer via Upwork: https://www.upwork.com/nx/wm/offer/103240375

    @sakluger Accepted the offer. Thanks.

  16. sakluger commented on Jul 24, 2024

    @sakluger
    Contributor

    Great, thanks! Payment is complete.

  17. moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collecton Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ReviewingHas a PR in review

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions