[HOLD for payment 2024-07-10] [$250] [CRITICAL] [UX Reliability] Transaction chat appears in the LHN without GBR/RBR or pinned in #focus mode

@puneetlath

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number:
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1718138583958989

Action Performed:

Set # focus mode in the preference
Have paid transactions with violations
Observe the LHN

Expected Result:

There should be no expense report items in the LHN without GBR RBR or pinned

Actual Result:

There are 3 transactions in the LHN
None of them have an RBR
They don't disappear even if they are clicked in and out
They all have missing translation errors
NOTE: Included the value of the transaction, report, and violations objects

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

transactionViolations_997722480123927492 from Onyx

[
    {
        "type": "violation",
        "name": "tagOutOfPolicy",
        "data": {
            "tagName": "Departments"
        }
    }
]

transactions_997722480123927492 from Onyx

{
    "amount": 0,
    "billable": false,
    "cardID": 0,
    "category": "Employee Office Meals",
    "comment": {
        "comment": "",
        "dismissedViolations": {
            "rter": {
                "puneet@expensify.com": "1705617523"
            }
        }
    },
    "created": "2024-01-15",
    "currency": "USD",
    "filename": "w_268a9217f35887f71c3bee2533cc8cdb8b1727fe.png",
    "merchant": "(none)",
    "modifiedAmount": -1000,
    "modifiedCreated": "",
    "modifiedCurrency": "USD",
    "modifiedMerchant": "Joe Coffee",
    "originalAmount": 0,
    "originalCurrency": "",
    "parentTransactionID": "",
    "receipt": {
        "receiptID": 686919710,
        "state": "SCANCOMPLETE",
        "source": "https://staging.expensify.com/receipts/w_268a9217f35887f71c3bee2533cc8cdb8b1727fe.png"
    },
    "reimbursable": true,
    "reportID": "3961426678972217",
    "status": "Posted",
    "tag": "COR (Eng, Concierge, SmartScan)",
    "transactionID": "997722480123927492",
    "hasEReceipt": false
}

transaction thread report_954645210570433 from Onyx

{
    "reportID": "954645210570433",
    "reportName": "Chat Report",
    "type": "chat",
    "chatType": "",
    "ownerAccountID": 0,
    "managerID": 0,
    "policyID": "0CFE78B25EBE2A0A",
    "participants": {
        "778531": {
            "hidden": false
        },
        "9645353": {
            "hidden": true
        },
        "10903701": {
            "hidden": true
        }
    },
    "isPinned": false,
    "lastReadTime": "2024-01-18 22:39:16.297",
    "lastReadSequenceNumber": 0,
    "lastVisibleActionCreated": "2024-01-18 22:38:43.554",
    "lastVisibleActionLastModified": "2024-01-18 22:38:43.554",
    "lastMessageText": "puneet@expensify.com",
    "lastActionType": "MODIFIEDEXPENSE",
    "lastActorAccountID": "778531",
    "notificationPreference": "always",
    "stateNum": 0,
    "statusNum": 0,
    "oldPolicyName": "",
    "isOwnPolicyExpenseChat": false,
    "lastMessageHtml": "puneet@expensify.com",
    "hasOutstandingChildRequest": false,
    "hasParentAccess": true,
    "parentReportID": "3961426678972217",
    "parentReportActionID": "352424088454139504",
    "writeCapability": "all",
    "description": "",
    "total": 0,
    "unheldTotal": 0,
    "currency": "USD",
    "chatReportID": "3961426678972217",
    "isWaitingOnBankAccount": false,
    "nonReimbursableTotal": 0,
    "isCancelledIOU": false,
    "permissions": [
        "read",
        "write",
        "share"
    ],
    "welcomeMessage": "",
    "errorFields": {},
    "participantAccountIDs": [
        778531,
        9645353,
        10903701
    ],
    "visibleChatMemberAccountIDs": [
        778531
    ]
}

expense report report_3961426678972217 from Onyx

{
    "reportID": "3961426678972217",
    "reportName": "Expense Report #3961426678972217",
    "type": "expense",
    "chatType": "",
    "ownerAccountID": 778531,
    "managerID": 778531,
    "policyID": "0CFE78B25EBE2A0A",
    "participants": {
        "778531": {
            "hidden": false
        },
        "9645353": {
            "hidden": false
        },
        "9713816": {
            "hidden": false
        },
        "10903701": {
            "hidden": true
        }
    },
    "participantAccountIDs": [
        778531,
        9645353,
        9713816,
        10903701
    ],
    "visibleChatMemberAccountIDs": [
        778531,
        9645353,
        9713816
    ],
    "isPinned": false,
    "lastReadTime": "2024-05-09 19:29:49.195",
    "lastReadSequenceNumber": 0,
    "lastVisibleActionCreated": "2024-05-09 18:31:00.614",
    "lastVisibleActionLastModified": "2024-05-09 18:31:00.614",
    "lastMessageText": "accounting@expensify.com exported this report to All Transaction Data Report (E…",
    "lastActionType": "EXPORTINTEGRATION",
    "lastActorAccountID": "9645353",
    "notificationPreference": "always",
    "stateNum": 6,
    "statusNum": 4,
    "oldPolicyName": "",
    "isOwnPolicyExpenseChat": false,
    "lastMessageHtml": "accounting@expensify.com exported this report to All Transaction Data Report (Expensify/Zedra/MA/SVFG)",
    "hasOutstandingChildRequest": false,
    "hasParentAccess": true,
    "parentReportID": "2753052891533545",
    "parentReportActionID": "7707689824575329558",
    "writeCapability": "all",
    "description": "",
    "total": -5151,
    "unheldTotal": -5151,
    "currency": "USD",
    "chatReportID": "2753052891533545",
    "isWaitingOnBankAccount": false,
    "nonReimbursableTotal": 0,
    "isCancelledIOU": false,
    "avatarUrl": null,
    "permissions": [],
    "welcomeMessage": "",
    "fieldList": null,
    "invoiceReceiver": null,
    "iouReportID": null,
    "isDeletedParentAction": null,
    "lastMentionedTime": null,
    "policyAvatar": null,
    "policyName": null,
    "tripData": null,
    "visibility": null
}

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bc533ed41d18d04f
Upwork Job ID: 1801673103970237987
Last Price Increase: 2024-06-21
Automatic offers:

ZhenjaHorbach | Reviewer | 102830239
truph01 | Contributor | 102830241

Issue Owner

Current Issue Owner: @mallenexpensify

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Job added to Upwork: https://www.upwork.com/jobs/~01bc533ed41d18d04f

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

@ZhenjaHorbach

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@ZhenjaHorbach

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: Transaction chat appears in the LHN without GBR/RBR #44233

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

@ZhenjaHorbach requires payment automatic offer (Reviewer)
@truph01 requires payment automatic offer (Contributor)

@ZhenjaHorbach

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
[@ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ZhenjaHorbach] Determine if we should create a regression test for this bug.
[@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@mallenexpensify

@mallenexpensify
I do not remember exactly
But it should be High Priority label here since this is CRITICAL issue
Sorry if I'm wrong 😅

@truph01

Contributor: @truph01 paid $250 via Upwork
Contributor+: @ZhenjaHorbach paid $250 via Upwork.

@ZhenjaHorbach the High Priority needs to be applied in order for the price to be auto-doubled. Details in #expensify-open-source here . Apologies for the confusion.

@ZhenjaHorbach can you fill out the BZ checklist above? Thx

@ZhenjaHorbach

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:

Unfortunately, I didn’t find the PR that introduced the bug

[@ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

NA

[@ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

NA

[@ZhenjaHorbach] Determine if we should create a regression test for this bug.

[@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Set # focus mode in the preference
Have paid transactions with violations
2.1 Create a new workspace
2.2. Enable "Members must categorize all expenses"
2.3. Submit a new expense without a category
2.4. Now that expense will have "Missing category" violation
2.5 We can see the expense has RBR in LHN
2.6. Now pay the IOU of that expense
Observe the LHN, the expense disappears.

Do we agree 👍 or 👎

@ZhenjaHorbach

Thanks @ZhenjaHorbach !
Test case GH

https://github.com/Expensify/Expensify/issues/412270

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-10] [$250] [CRITICAL] [UX Reliability] Transaction chat appears in the LHN without GBR/RBR or pinned in #focus mode #43602

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

37 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-07-10] [$250] [CRITICAL] [UX Reliability] Transaction chat appears in the LHN without GBR/RBR or pinned in #focus mode #43602

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 12, 2024

MelvinBot commented on Jun 12, 2024

melvin-bot commented on Jun 14, 2024

melvin-bot commented on Jun 14, 2024

melvin-bot commented on Jun 14, 2024

37 remaining items

melvin-bot commented on Jul 3, 2024

melvin-bot commented on Jul 3, 2024

melvin-bot commented on Jul 3, 2024

ZhenjaHorbach commented on Jul 10, 2024

mallenexpensify commented on Jul 11, 2024

ZhenjaHorbach commented on Jul 11, 2024

mallenexpensify commented on Jul 12, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions