[HOLD for payment 2024-07-17] [$250] Inbox - The entire page blinks when clicking Inbox on Inbox page

@puneetlath

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
On Inbox page, click Inbox icon
Refresh the page
Click Inbox

Expected Result:

The entire page will not blink

Actual Result:

The entire page blinks
This issue is not reproduced on Search and Account settings page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6510872_1718200620155.20240612_215345.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f33295394aa2f176
Upwork Job ID: 1801707280294774711
Last Price Increase: 2024-06-21
Automatic offers:

alitoshmatov | Reviewer | 102890680
truph01 | Contributor | 102890682

Issue Owner

Current Issue Owner: @puneetlath

@puneetlath

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Job added to Upwork: https://www.upwork.com/jobs/~01f33295394aa2f176

@alitoshmatov

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

The entire page blinks
This issue is not reproduced on Search and Account settings page

What is the root cause of that problem?

When click on "Inbox" button, we call:

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx

Lines 73 to 76 in 75c104b

    
           const navigateToChats = useCallback(() => { 
        
               const route = activeWorkspaceID ? (`/w/${activeWorkspaceID}/home` as Route) : ROUTES.HOME; 
        
               Navigation.navigate(route); 
        
           }, [activeWorkspaceID]);

In navigate function, this logic is called:

App/src/libs/Navigation/linkTo/index.ts

Lines 142 to 146 in 75c104b

    
           const actionForBottomTabNavigator = getActionForBottomTabNavigator(action, rootState, policyID, shouldNavigate); 
        
           if (!actionForBottomTabNavigator) { 
        
               return; 
        
           }

In expected, actionForBottomTabNavigator in above should be undefined, so the function will do nothing if user has already been in the /home page, but in this case, actionForBottomTabNavigator in not undefined.
So let's take a look at the getActionForBottomTabNavigator to find the RCA.

In getActionForBottomTabNavigator, we already have logic to do nothing if the current bottom tab is the same as the one we want to navigate to:

App/src/libs/Navigation/linkTo/getActionForBottomTabNavigator.ts

Lines 31 to 39 in 75c104b

    
           // Check if the current bottom tab is the same as the one we want to navigate to. If it is, we don't need to do anything. 
        
           const bottomTabCurrentTab = getTopmostBottomTabRoute(state); 
        
           const bottomTabParams = bottomTabCurrentTab?.params as Record<string, string | undefined>; 
        
           // Verify if the policyID is different than the one we are currently on. If it is, we need to navigate to the new policyID. 
        
           const isNewPolicy = bottomTabParams?.policyID !== payloadParams?.policyID; 
        
           if (bottomTabCurrentTab?.name === screen && !shouldNavigate && !isNewPolicy) { 
        
               return; 
        
           }

In this case, the expected is that isNewPolicy: false but actually, it is true because isNewPolicy = bottomTabParams?.policyID !== payloadParams?.policyID with bottomTabParams?.policyID: undefined and payloadParams?.policyID: '' (we can console.log in this line to see these values).

What changes do you think we should make in order to solve the problem?

Base on the above, we need to cover the case bottomTabParams?.policyID: undefined and payloadParams?.policyID: ''. We can update this:

App/src/libs/Navigation/linkTo/getActionForBottomTabNavigator.ts

Line 36 in 75c104b

const isNewPolicy = bottomTabParams?.policyID !== payloadParams?.policyID;

to:

    const isNewPolicy = (!!bottomTabParams?.policyID || !!payloadParams?.policyID) &&  bottomTabParams?.policyID !== payloadParams?.policyID;

What alternative solutions did you explore? (Optional)

We can also disable or early return this function:

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx

Line 73 in 75c104b

const navigateToChats = useCallback(() => {

if currentTabName === SCREENS.HOME. Do the same with other button tabs.

@truph01

@truph01 Thank you for your proposal, your RCA is correct and your solution does solve the problem. But this issue is also happening for search page, when you go to search page, refresh and then click on search page expenses list is refreshing and blinking. Ideally we should solve that too

@alitoshmatov

@alitoshmatov

this issue is also happening for search page

It can be fixed with my alternative solution.

@alitoshmatov

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: The entire page blinks when clicking Inbox #44528

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

@alitoshmatov requires payment automatic offer (Reviewer)
@truph01 requires payment automatic offer (Contributor)

@alitoshmatov

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
[@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@alitoshmatov] Determine if we should create a regression test for this bug.
[@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@alitoshmatov

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: The entire page blinks when clicking Inbox #44528

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

@alitoshmatov requires payment automatic offer (Reviewer)
@truph01 requires payment automatic offer (Contributor)

@alitoshmatov

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
[@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@alitoshmatov] Determine if we should create a regression test for this bug.
[@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@alitoshmatov

@alitoshmatov friendly reminder about the checklist so we can pay tomorrow.

@truph01

@truph01 has been paid. Still waiting on the checklist for @alitoshmatov.

The PR that introduced the bug has been identified. Link to the PR: Fix chat navigation #42684
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42684/files#r1681312172
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
Determine if we should create a regression test for this bug. I don't think regression test is needed since it is pretty noticeable bug

All paid. Thanks everyone!

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-17] [$250] Inbox - The entire page blinks when clicking Inbox on Inbox page #43585

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

36 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const navigateToChats = useCallback(() => {
	const route = activeWorkspaceID ? (`/w/${activeWorkspaceID}/home` as Route) : ROUTES.HOME;
	Navigation.navigate(route);
	}, [activeWorkspaceID]);

	const actionForBottomTabNavigator = getActionForBottomTabNavigator(action, rootState, policyID, shouldNavigate);

	if (!actionForBottomTabNavigator) {
	return;
	}

	// Check if the current bottom tab is the same as the one we want to navigate to. If it is, we don't need to do anything.
	const bottomTabCurrentTab = getTopmostBottomTabRoute(state);
	const bottomTabParams = bottomTabCurrentTab?.params as Record<string, string \| undefined>;

	// Verify if the policyID is different than the one we are currently on. If it is, we need to navigate to the new policyID.
	const isNewPolicy = bottomTabParams?.policyID !== payloadParams?.policyID;
	if (bottomTabCurrentTab?.name === screen && !shouldNavigate && !isNewPolicy) {
	return;
	}

[HOLD for payment 2024-07-17] [$250] Inbox - The entire page blinks when clicking Inbox on Inbox page #43585

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 12, 2024

melvin-bot commented on Jun 14, 2024

melvin-bot commented on Jun 14, 2024

truph01 commented on Jun 15, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

alitoshmatov commented on Jun 18, 2024

truph01 commented on Jun 18, 2024

36 remaining items

melvin-bot commented on Jul 10, 2024

melvin-bot commented on Jul 10, 2024

melvin-bot commented on Jul 15, 2024

melvin-bot commented on Jul 15, 2024

puneetlath commented on Jul 16, 2024

puneetlath commented on Jul 17, 2024

alitoshmatov commented on Jul 17, 2024

puneetlath commented on Jul 17, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions