Repository navigation
[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$125] Small font updates for Search page #43512
Description
We just released our new Search page, but we noticed quite a few font inconsistencies that we want to update.
On desktop:
- Let's use our normal font size (15px) for every column. This means undoing the smaller sizes for things like the To/From columns, or Tax column.
- Let's use a gap of 8px between the avatar and the From/To names:
- Let's remove any Expensify New Kansas from the table as well
On mobile:
- Let's only use our normal font size (15px) and our micro font size (11px)
- Merchant and amount will use the normal font size, everything else gets micro
- Let's remove the bold style from the from/to, as well as update the spacing to use 8px between avatar and name
cc @Expensify/design @luacmartins @iwiznia
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~017822f748f43e483b
- Upwork Job ID: 1800776935107005435
- Last Price Increase: 2024-06-12
- Automatic offers:
- c3024 | Reviewer | 102708541
Activity
melvin-bot commentedon Jun 11, 2024
Current assignee @shawnborton is eligible for the Design assigner, not assigning anyone new.
[-]Small font updates for Search page[/-][+][$250] Small font updates for Search page[/+]melvin-bot commentedon Jun 12, 2024
Job added to Upwork: https://www.upwork.com/jobs/~017822f748f43e483b
melvin-bot commentedon Jun 12, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (
External)melvin-bot commentedon Jun 12, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.shawnborton commentedon Jun 12, 2024
Given that these are just small style adjustments, I think we can reduce the price down to $125. Thoughts @sakluger?
truph01 commentedon Jun 12, 2024
@shawnborton I'd volunteer to take this issue. The changes are straight forward so I don't think we need a full proposal detailing the code part for every small change here right?
Proposal
Please re-state the problem that we are trying to solve in this issue.
We want to add some small font updates for Search page
What is the root cause of that problem?
This is a new requested feature, not a bug
What changes do you think we should make in order to solve the problem?
Just follow the list of changes here #43512 (comment), they are all straight-forward changes
An example of changes needed for one of the item:
For To/From columns, replace
textMicroBoldhere withtextStrong, or create a newtextBoldstyle that is similar totextMicroBoldbut doensn't have these linesFor Tax column, remove styles.label here. We can add
lineHeight: variables.lineHeightLarge,fromlabelif it's still needed (I think we don't need it)There're other fields similar to the Tax column like Date, Merchant column
Replace
styles.gap1here bystyles.gap1. Or remove thestyles.gap1and addpr2to theAvatarThere's
Expensify New Kansasfont in here inReportListItem, we can removestyles.textNewKansasNormal(or just the font family).There's that font used in the Header too can can be removed like that, but I guess we should not remove the font there.
Mobile-specific changes (can alternate using
isLargeScreenWidth/isSmallScreenWidth):Don't use any specific font style for Merchant (remove
styles.label) and Amount, but usestyles.textMicrofor other cellsReplace
textMicroBoldwithtextMicrohere. That means it's bold on Desktop but not mobile, let's consider if they should be consistent (bold or not)Covered in desktop changes
To achieve this, we can add customized styles by adding
styleprop to cell components likeMerchantCell,UserInfoCell. And add the correctstyledepending on where the cell is rendered inWhat alternative solutions did you explore? (Optional)
22 remaining items
melvin-bot commentedon Jun 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 25, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sakluger commentedon Jul 2, 2024
Summarizing payment on this issue:
Contributor: @truph01 $125 - Please apply to the Upwork job: https://www.upwork.com/jobs/~017822f748f43e483b
Contributor+: @c3024 $125, paid via Upwork
I don't think we need to complete the BZ checklist for this one because it's just a minor font change.
sakluger commentedon Jul 3, 2024
@truph01 I found your Upwork profile and sent you an offer: https://www.upwork.com/nx/wm/offer/102974684/
Could you please let me know once you've accepted the offer? Thanks!
truph01 commentedon Jul 3, 2024
@sakluger Accepted, thanks 🙏 🙏
sakluger commentedon Jul 3, 2024
Thank you! All paid out 👍
[-][HOLD for payment 2024-07-02] [$125] Small font updates for Search page[/-][+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$125] Small font updates for Search page[/+]melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: