Repository navigation
[HOLD for payment 2024-06-28] [$125] [Search v1] No background color placeholder exists for receipt thumbnail #43393
Description
Activity
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.The color should be the same that we use for the empty state thumbnail:
Which probably means we need to consider the hover state too - I think we bump that background color a shade up when the expense or report row is hovered.
Job added to Upwork: https://www.upwork.com/jobs/~019803a773929eed48
- changed the title
[-][Search v1] No background color placeholder exists for receipt thumbnail[/-][+][$250] [Search v1] No background color placeholder exists for receipt thumbnail[/+]on Jun 10, 2024 Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (
External)- changed the title
[-][$250] [Search v1] No background color placeholder exists for receipt thumbnail[/-][+][$125] [Search v1] No background color placeholder exists for receipt thumbnail[/+]on Jun 10, 2024 20 remaining items
- changed the title
[-][$125] [Search v1] No background color placeholder exists for receipt thumbnail[/-][+][HOLD for payment 2024-06-28] [$125] [Search v1] No background color placeholder exists for receipt thumbnail[/+]on Jun 21, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-28. 🎊
For reference, here are some details about the assignees on this issue:
- @Krishna2323 requires payment automatic offer (Contributor)
- @dukenv0307 requires payment automatic offer (Reviewer)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
- [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@dukenv0307] Determine if we should create a regression test for this bug.
- [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
I don't think we need a regression test for this, and it was a cheeky bug in a new feature release.
Payment summary as follows:
- $125 to @Krishna2323 for the fix
- $125 to @dukenv0307 for C+
Paid both, closing!
- moved this from Polish to Done in [#whatsnext] #wave-collect
on Jun 28, 2024
Coming from this thread, the receipt thumbnail doesn't have a placeholder background color.
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @trjExpensify