Skip to content

[HOLD for payment 2024-06-28] [$250] Hold expenses - "iou.genericHoldExpenseFailureMessage" error when holding a paid expense #43279

Closed
Closed
[HOLD for payment 2024-06-28] [$250] Hold expenses - "iou.genericHoldExpenseFailureMessage" error when holding a paid expense#43279
Assignees
alexpensifyJulesssssparasharrajatbernhardoj
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Description

@lanitochka17
lanitochka17
opened on Jun 7, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4605660
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. [User A] Submit expense to User B
  3. [User A] Go to transaction thread
  4. [User A] Go to 3-dot menu > Hold
  5. [User A] Leave the Hold RHP open
  6. [User B] Pay the expense
  7. [User A] After the expense is paid on their end, enter a reason and save it

Expected Result:

User A will receive an error that the expense cannot be held/edited

Actual Result:

User A receives the error "iou.genericHoldExpenseFailureMessage"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6504952_1717762800154.bandicam_2024-06-07_20-15-53-640.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015aa1fc4dd1f5a60d
  • Upwork Job ID: 1800577247384003062
  • Last Price Increase: 2024-06-11
  • Automatic offers:
    • bernhardoj | Contributor | 102706048
Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. lanitochka17
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 7, 2024

  2. melvin-bot commented on Jun 7, 2024

    @melvin-bot
    melvin-botbot
    on Jun 7, 2024 – with Melvin Bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot
    assigned
    alexpensify
    on Jun 7, 2024

  4. bernhardoj commented on Jun 7, 2024

    @bernhardoj
    bernhardoj
    on Jun 7, 2024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The error message key is shown instead of the text when hold message error is shown.

    What is the root cause of that problem?

    In the failure data of hold request, we set the error key to iou.genericHoldExpenseFailureMessage.

    App/src/libs/actions/IOU.ts

    Line 6791 in b94ccf3

    errors: ErrorUtils.getMicroSecondOnyxError('iou.genericHoldExpenseFailureMessage'),

    However, this error message key doesn't exist on the translation file, so the error key is shown instead.

    If we open the translation file,

    App/src/languages/en.ts

    Line 738 in b94ccf3

    genericHoldExpenseFailureMessage: 'Unexpected error while holding the expense. Please try again later.',

    The genericHoldExpenseFailureMessage is located inside the iou.error object.

    What changes do you think we should make in order to solve the problem?

    Update the error key to iou.error.genericHoldExpenseFailureMessage

  5. alexpensify commented on Jun 10, 2024

    @alexpensify
    alexpensify
    on Jun 10, 2024
    Contributor

    This one slipped my radar; I will test it tomorrow.

  6. alexpensify commented on Jun 11, 2024

    @alexpensify
    alexpensify
    on Jun 11, 2024
    Contributor

    I didn't get a generic error but I was able to save the Hold action.

    2024-06-11_10-11-52

  7. alexpensify
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 11, 2024
  8. melvin-bot
    changed the title [-]Hold expenses - "iou.genericHoldExpenseFailureMessage" error when holding a paid expense[/-] [+][$250] Hold expenses - "iou.genericHoldExpenseFailureMessage" error when holding a paid expense[/+] on Jun 11, 2024

  9. melvin-bot commented on Jun 11, 2024

    @melvin-bot
    melvin-botbot
    on Jun 11, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~015aa1fc4dd1f5a60d

  10. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 11, 2024
  11. melvin-bot
    assigned
    parasharrajat
    on Jun 11, 2024

  12. melvin-bot commented on Jun 11, 2024

    @melvin-bot
    melvin-botbot
    on Jun 11, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  13. alexpensify
    added this to [#whatsnext] #vip-vsbon Jun 11, 2024

  14. alexpensify commented on Jun 11, 2024

    @alexpensify
    alexpensify
    on Jun 11, 2024
    Contributor

    @parasharrajat can you please review if this proposal will fix the issue and flag when an expense can't be put on Hold? Thanks!

  15. 13 remaining items

  16. melvin-bot
    added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Jun 21, 2024
  17. melvin-bot
    changed the title [-][$250] Hold expenses - "iou.genericHoldExpenseFailureMessage" error when holding a paid expense[/-] [+][HOLD for payment 2024-06-28] [$250] Hold expenses - "iou.genericHoldExpenseFailureMessage" error when holding a paid expense[/+] on Jun 21, 2024

  18. melvin-bot commented on Jun 21, 2024

    @melvin-bot
    melvin-botbot
    on Jun 21, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  19. melvin-bot
    removed
    ReviewingHas a PR in review
    on Jun 21, 2024

  20. melvin-bot commented on Jun 21, 2024

    @melvin-bot
    melvin-botbot
    on Jun 21, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-28. 🎊

    For reference, here are some details about the assignees on this issue:

  21. melvin-bot commented on Jun 21, 2024

    @melvin-bot
    melvin-botbot
    on Jun 21, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@parasharrajat] Determine if we should create a regression test for this bug.
    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  22. parasharrajat commented on Jun 22, 2024

    @parasharrajat
    parasharrajat
    on Jun 22, 2024
    Member

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Steps

    1. [User A] Submit multiple expenses to User B
    2. [User A] Go to one of the transaction thread
    3. [User A] Press the 3-dot menu and choose Hold
    4. [User B] Pay the expense
    5. [User A] After the expense is paid on their end, enter a hold reason and save it
    6. [User A] Verify the unexpected error message is shown

    Do you agree 👍 or 👎 ?

  23. Julesssss commented on Jun 24, 2024

    @Julesssss
    Julesssss
    on Jun 24, 2024
    Contributor

    Test steps are fine, but I don't think we need a full regression test for this simple text issue tbh.

  24. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Jun 27, 2024

  25. alexpensify commented on Jun 27, 2024

    @alexpensify
    alexpensify
    on Jun 27, 2024
    Contributor

    Automation worked here, I'll work on the payment process tomorrow.

  26. alexpensify commented on Jun 28, 2024

    @alexpensify
    alexpensify
    on Jun 28, 2024
    Contributor

    Payouts due: 2024-06-28

    Upwork job is here.

    Status: @parasharrajat please submit a request in Chat. @bernhardoj has been paid in Upwork. I now need to create the regression test.

  27. alexpensify
    closed this as completedon Jun 28, 2024

  28. parasharrajat commented on Jun 29, 2024

    @parasharrajat
    parasharrajat
    on Jun 29, 2024
    Member

    Payment requested as per #43279 (comment)

  29. JmillsExpensify commented on Jul 2, 2024

    @JmillsExpensify
    JmillsExpensify
    on Jul 2, 2024
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions