[HOLD for payment 2024-07-17] [$250] Profile - Profile changes to Hidden and "Email not found" error when messaging Hidden user

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.80-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat
3. Enter a non-existing email
4. Select the email
5. Quickly click on the chat header after landing on the DM
6. After the profile changes to Hidden, click Message

Expected Result:

In Step 5, the user profile RHP will remain unchanged

Actual Result:

In Step 5, the user profile RHP changes to Hidden
When clicking Message, app redirects to chat with another user with the error "Email not found"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6504945_1717762402806.bandicam_2024-06-07_20-08-22-644.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018004b4dcf5d57a3b
• Upwork Job ID: 1800107416738330577
• Last Price Increase: 2024-07-01
• Automatic offers:
• ZhenjaHorbach | Reviewer | 102957514
• bernhardoj | Contributor | 102957518

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Profile page changes to hidden and error when pressing Message on a new user.

What is the root cause of that problem?

When we start a new chat, we will create an optimistic personal detail for the user. We actually have a disabled condition to disable the press when the user is optimistic.

App/src/pages/home/HeaderView.tsx

Line 258 in bb6e7eb

disabled={shouldDisableDetailPage}

App/src/libs/ReportUtils.ts

Lines 1124 to 1132 in bb6e7eb

	function shouldDisableDetailPage(report: OnyxEntry<Report>): boolean {
	const participantAccountIDs = Object.keys(report?.participants ?? {}).map(Number);
	if (isChatRoom(report) || isPolicyExpenseChat(report) || isChatThread(report) || isTaskReport(report)) {
	return false;
	}
	if (participantAccountIDs.length === 1) {
	return isOptimisticPersonalDetail(participantAccountIDs[0]);
	}

However, the participants contains both the user and the current user, so the length is 0, thus the participantAccountIDs.length === 1 condition is never satisfied. This happens after we migrate from report.participantAccountIDs to report.participants.

What changes do you think we should make in order to solve the problem?

Filter out current user from report.participants. We can also optionally replace participantAccountIDs.length === 1 with isOneOnOneChat.

if (isOneOnOneChat(report)) {
    const participantAccountIDs = Object.keys(report?.participants ?? {}).map(Number).filter((accountID) => accountID !== currentUserAccountID);
    return isOptimisticPersonalDetail(participantAccountIDs[0]);
}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018004b4dcf5d57a3b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)