Repository navigation
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Position 'Track tax' is shifted to the left relative to other data on the settings page #43242
Description
Activity
Triggered auto assignment to @MonilBhavsar (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Position 'Track tax' is shifted to the left relative to other data on the settings page
What is the root cause of that problem?
We use a horizontal margin
styles.mh4inconsistent with others on the page.What changes do you think we should make in order to solve the problem?
We will use
styles.mh5as the horizontal margin on the page.<View style={[styles.mh5]}>
Alternatively
We can only increase the left margin for the element.
15 remaining items
Issue is fixed
Reacted by Monil Bhavsar- changed the title
[-]Position 'Track tax' is shifted to the left relative to other data on the settings page[/-][+][HOLD for payment 2024-06-18] Position 'Track tax' is shifted to the left relative to other data on the settings page[/+]on Jun 11, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-18. 🎊
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
- [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@MonilBhavsar] Determine if we should create a regression test for this bug.
- [@MonilBhavsar] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
- changed the title
[-][HOLD for payment 2024-06-18] Position 'Track tax' is shifted to the left relative to other data on the settings page[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Position 'Track tax' is shifted to the left relative to other data on the settings page[/+]on Jun 13, 2024 The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. 🎊
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
- [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@MonilBhavsar] Determine if we should create a regression test for this bug.
- [@MonilBhavsar] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
issue found around #43182
Version Number: 1.4.80-8
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Go to URL https://staging.new.expensify.com/
Login with any account
Create WS if needed
Enable Distance Rate -> Settings
Put your attention to the position of
Track taxExpected Result:
Track taxitem is located on the same level as the othersActual Result:
Position 'Track tax' is shifted to the left
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6504396_1717710138927.bandicam_2024-06-07_00-21-02-415.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @trjExpensify