[HOLD for payment 2024-06-20] [$250] Track tax - App crashes after assigning deleted tax rate to distance rate offline

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found around explortary of 42141
Version Number: 1.4.80-9
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

• Distance rates and Taxes are enabled.
• Track tax is enabled.

1. Go to staging.new.expensify.com
2. Go offline.
3. Go to Taxes.
4. Delete a tax.
5. Go to Distance rates.
6. Tap on any rate.
7. Tap Tax rate.
8. Select the deleted tax rate in Step 4.
9. Go online.
10. Open the Tax rate RHP while online.

Expected Result:

In Step 8, the deleted tax rate should be crossed out so that it cannot be assigned to distance rate after it is deleted offline.

Actual Result:

In Step 8. the deleted tax rate can be assigned to the distance rate.
As a result, app crashes after going online when opening distance rate RHP.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6504472_1717718817546!staging.new.expensify.com-1717718558471.txt

Bug6504472_1717718817576.20240607_075958.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018b6d815717d1c289
• Upwork Job ID: 1799120175681501137
• Last Price Increase: 2024-06-07

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kavimuru]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[kavimuru]

We think this bug might be related to #wave-collect - Release 1

[nkdengineer]

I'll raise PR soon to fix this regression