Repository navigation
[$250] When editing comment, copy and paste text that has trailing \n, console error appears and send button changed to grey, can not send #43239
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.80-9
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @badeggg
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1717559130850559
Action Performed:
- Open any chat page
- in the composer box, copy text that has trailing a trailing line break, \n, paste it to the composer box, ie.
test
Expected Result:
No error logging in console and can send text
Actual Result:
Console error appears and send button changed to grey, can not send
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
cc.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01296f154c567ad13d
- Upwork Job ID: 1802744039321176346
- Last Price Increase: 2024-06-17
Activity
melvin-bot commentedon Jun 7, 2024
Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.
situchan commentedon Jun 7, 2024
Here's clear repro step:
melvin-bot commentedon Jun 10, 2024
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mallenexpensify commentedon Jun 11, 2024
The issue appears to have to do with the trailing space or linebreak at the end, when it's removed, you can post. Does that sound right @badeggg and @situchan
w_e5779e27696d0562df5cc72192db49420213f1cc.mp4
MelvinBot commentedon Jun 11, 2024
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
badeggg commentedon Jun 11, 2024
Not exactly, trailing line break can repro, trailing space can not.
Actually, you just need change the comment just a little bit after pasting (e.g. add letter 'a' in what ever place), you can post.
By the way, is this issue waiting proposals from external?
badeggg commentedon Jun 11, 2024
If you are using vscode, select two lines(one line is ok too) and
cmd+cto copy, like this:If you use vim,
shift+venter visual mode,shift+"+*+yto copy, like this:Paste to composer box, error appears
situchan commentedon Jun 12, 2024
The video you shared correctly explains the bug. Send button is disabled along with console error.
14 remaining items
mallenexpensify commentedon Jun 20, 2024
Thanks @BartoszGrajdek , I added to the
Live Markdownproject, removedHelp Wantedand bumped to weekly.@badeggg , hang tight for now plz while we get a better handle on managing markdown improvements more holistically.
BartoszGrajdek commentedon Jun 20, 2024
Thank you @mallenexpensify 🙌🏻
I've added a more in-depth update here. I'll be looking through proposals in the coming days. What @badeggg is suggesting to change is something that has already caused quite a few problems, so I'd rather test it carefully.
melvin-bot commentedon Jun 21, 2024
@eVoloshchak @mallenexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
BartoszGrajdek commentedon Jun 24, 2024
I believe this was fixed here! Can we get it retested?
These changes are also coming into
react-native-live-markdownlater this week.cc @mallenexpensify
mallenexpensify commentedon Jun 25, 2024
Unable to reproduce on web, staging, Chrome. Closing. Thanks @BartoszGrajdek !