Skip to content

[HOLD for payment 2024-07-10] [$250] [Search v1] Apply hover style to row if button is hovered #43233

Description

@luacmartins

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

Coming from this comment

  1. Navigate to the new search page
  2. Hover a row
  3. Notice that it is highlighted
  4. Hover the button within the row
  5. Notice that the button is highlighted but the row is no longer highlighted

Expected Result:

Row should be highlighted

Actual Result:

Row is not highlighted

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013a5b2e0e021c1c12
  • Upwork Job ID: 1798845264683098328
  • Last Price Increase: 2024-07-15
  • Automatic offers:
    • alitoshmatov | Reviewer | 102798152
    • dominictb | Contributor | 102798154
Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 6, 2024
  2. self-assigned this
    on Jun 6, 2024
  3. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 6, 2024
  5. changed the title [-][Search v1] Apply hover style to row if button is hovered[/-] [+][$250] [Search v1] Apply hover style to row if button is hovered[/+] on Jun 6, 2024
  6. melvin-bot commented on Jun 6, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 6, 2024
  8. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

  9. changed the title [-][$250] [Search v1] Apply hover style to row if button is hovered[/-] [+][$125] [Search v1] Apply hover style to row if button is hovered[/+] on Jun 6, 2024
  10. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    Upwork job price has been updated to $125

  11. BishalN commented on Jun 7, 2024

    @BishalN

    Contributor details
    Your Expensify account email: neupanebishal07@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01182d696a155c95ce

  12. 51 remaining items

  13. dylanexpensify commented on Jul 12, 2024

    @dylanexpensify
    Contributor

    Payment summary:

    Please apply/request!

  14. dylanexpensify commented on Jul 12, 2024

    @dylanexpensify
    Contributor

    @dominictb please accept offer! 🙇‍♂️

  15. dominictb commented on Jul 15, 2024

    @dominictb
    Contributor

    @luacmartins @dylanexpensify Could we keep the $250 original price for this issue?

    I saw it being reduced by half, however I believe this is not a simple issue, it requires non-intuitive use of mouse event, and I needed to dig into the library being used to find the RCA. Also there was a request to fix all cases of Pressables across the app and we've done that, it requires a lot of testing to make sure there's no regression.

    Appreciate your thought on this one!

  16. luacmartins commented on Jul 15, 2024

    @luacmartins
    ContributorAuthor

    Sure, we can keep this one at the regular bounty.

  17. changed the title [-][HOLD for payment 2024-07-10] [$125] [Search v1] Apply hover style to row if button is hovered[/-] [+][HOLD for payment 2024-07-10] [$250] [Search v1] Apply hover style to row if button is hovered[/+] on Jul 15, 2024
  18. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    Upwork job price has been updated to $250

  19. dylanexpensify commented on Jul 15, 2024

    @dylanexpensify
    Contributor

    Nice, @dominictb accept the offer as it is, and I'll add another $125 as a bonus! @alitoshmatov I'll send a bonus for same amount to you as well!

  20. dominictb commented on Jul 15, 2024

    @dominictb
    Contributor

    Thank you @luacmartins @dylanexpensify

    I accepted the offer

  21. dylanexpensify commented on Jul 17, 2024

    @dylanexpensify
    Contributor

    Nice, paying!

  22. dylanexpensify commented on Jul 17, 2024

    @dylanexpensify
    Contributor

    all done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions