Workspace - "Find a workspace" text is missing from search bar

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.80-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+emilio@applause.expensifail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #41158

Action Performed:

Open New Expensify app
Sign into a valid account
Click on WS switcher and observe the search bar

Expected Result:

According to the PR, there should be a search bar with the text "Find a workspace"

Actual Result:

There is no text within the search bar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

@CortneyOfstad

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@CortneyOfstad

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - "Find a workspace" text is missing from search bar

What is the root cause of that problem?

We are using common.search.

App/src/pages/WorkspaceSwitcherPage/index.tsx

Line 190 in 4679122

    
           textInputLabel={usersWorkspaces.length >= CONST.WORKSPACE_SWITCHER.MINIMUM_WORKSPACES_TO_SHOW_SEARCH ? translate('common.search') : undefined}

What changes do you think we should make in order to solve the problem?

We should be using workspace.switcher.placeholder.

App/src/languages/en.ts

Line 2326 in 4679122

placeholder: 'Find a workspace',

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong placeholder and missing icon for the search input

What is the root cause of that problem?

The workspace search input is missing the icon and has the wrong place holder input.

What changes do you think we should make in order to solve the problem?

1- Change placeholder text

Change common.search to workspace.switcher.placeholder

App/src/pages/WorkspaceSwitcherPage/index.tsx

Line 190 in 4679122

    
           textInputLabel={usersWorkspaces.length >= CONST.WORKSPACE_SWITCHER.MINIMUM_WORKSPACES_TO_SHOW_SEARCH ? translate('common.search') : undefined}

2- add the icon on the left

Use textInputIconLeft={Expensicons.MagnifyingGlass} here

App/src/pages/WorkspaceSwitcherPage/index.tsx

Lines 186 to 197 in 4679122

    
           <SelectionList<WorkspaceListItem> 
        
               ListItem={UserListItem} 
        
               sections={sections} 
        
               onSelectRow={selectPolicy} 
        
               textInputLabel={usersWorkspaces.length >= CONST.WORKSPACE_SWITCHER.MINIMUM_WORKSPACES_TO_SHOW_SEARCH ? translate('common.search') : undefined} 
        
               textInputValue={searchTerm} 
        
               onChangeText={setSearchTerm} 
        
               headerMessage={headerMessage} 
        
               listFooterContent={shouldShowCreateWorkspace ? WorkspaceCardCreateAWorkspaceInstance : null} 
        
               initiallyFocusedOptionKey={activeWorkspaceID ?? CONST.WORKSPACE_SWITCHER.NAME} 
        
               showLoadingPlaceholder={fetchStatus.status === 'loading' || !didScreenTransitionEnd} 
        
           />

and adjust the style to make it fit the design

What alternative solutions did you explore?

Going to check with the design team on this, as I am not sure if the text was not listed intentionally.

Confirmed with the design team here, that this is not a bug as how it's displayed now is the same as if you're searching for a category (for example) when you submit an expense.

Closing!

Navigation Menu

Repository navigation

Workspace - "Find a workspace" text is missing from search bar #43220

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore?

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<SelectionList<WorkspaceListItem>
	ListItem={UserListItem}
	sections={sections}
	onSelectRow={selectPolicy}
	textInputLabel={usersWorkspaces.length >= CONST.WORKSPACE_SWITCHER.MINIMUM_WORKSPACES_TO_SHOW_SEARCH ? translate('common.search') : undefined}
	textInputValue={searchTerm}
	onChangeText={setSearchTerm}
	headerMessage={headerMessage}
	listFooterContent={shouldShowCreateWorkspace ? WorkspaceCardCreateAWorkspaceInstance : null}
	initiallyFocusedOptionKey={activeWorkspaceID ?? CONST.WORKSPACE_SWITCHER.NAME}
	showLoadingPlaceholder={fetchStatus.status === 'loading' \|\| !didScreenTransitionEnd}
	/>

Workspace - "Find a workspace" text is missing from search bar #43220

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 6, 2024

lanitochka17 commented on Jun 6, 2024

Krishna2323 commented on Jun 6, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dragnoir commented on Jun 7, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore?

CortneyOfstad commented on Jun 10, 2024

CortneyOfstad commented on Jun 10, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions