Skip to content

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] [Search v1] Columns are shown/hidden depending on sorting #43205

Description

@luacmartins

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

  1. Go to the new search page
  2. Sort the values by any column
  3. Notice that the Categories, Tags or Taxes columns might be shown/hidden creating a jarring UX

Expected Result:

Columns should be consistent

Actual Result:

UX is jarring with columns being added/removed depending on sorting

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011f1a98bee1b0b207
  • Upwork Job ID: 1800124308908329759
  • Last Price Increase: 2024-06-10
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @laurenreidexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 6, 2024
  2. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. added
    ReviewingHas a PR in review
    and removed on Jun 6, 2024
  4. changed the title [-][Search v1] Columns are shown/hidden depending on sorting[/-] [+][$250] [Search v1] Columns are shown/hidden depending on sorting[/+] on Jun 10, 2024
  5. melvin-bot commented on Jun 10, 2024

    @melvin-bot
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 10, 2024
  7. melvin-bot commented on Jun 10, 2024

    @melvin-bot

    Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

  8. 14 remaining items

  9. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-18. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ishpaul777 requires payment (Needs manual offer from BZ)
  10. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
    • [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ishpaul777] Determine if we should create a regression test for this bug.
    • [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. changed the title [-][HOLD for payment 2024-06-18] [$250] [Search v1] Columns are shown/hidden depending on sorting[/-] [+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] [Search v1] Columns are shown/hidden depending on sorting[/+] on Jun 13, 2024
  12. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-20. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ishpaul777 requires payment (Needs manual offer from BZ)
  13. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
    • [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ishpaul777] Determine if we should create a regression test for this bug.
    • [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. laurenreidexpensify commented on Jun 19, 2024

    @laurenreidexpensify
    Contributor

    @ishpaul777 please accept offer in Upwork and complete steps above thanks

  15. ishpaul777 commented on Jun 19, 2024

    @ishpaul777
    Contributor

    [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: #42248
    [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42248/files#r1646558444
    [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
    [@ishpaul777] Determine if we should create a regression test for this bug. - Not required
    [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N/A

  16. ishpaul777 commented on Jun 19, 2024

    @ishpaul777
    Contributor

    Accepted offer! Thank you!

  17. laurenreidexpensify commented on Jun 20, 2024

    @laurenreidexpensify
    Contributor

    Payment Summary:

    C+ Review @ishpaul777 paid $250 in Upwork

  18. moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collecton Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions