[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Pay someone - Replies sent to paid system message appear again in transaction thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.80-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #42894

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Pay someone
3. Enter amount, select a user and pay them
4. Go to the transaction thread
5. Right click on the system message > Reply in thread
6. Send a reply
7. Click on the header subtitle to return to transaction thread

Expected Result:

In Step 5, the paid system message will appear in the thread
In Step 7, reply sent in Step 6 will not appear in the transaction thread

Actual Result:

In Step 5, the paid system message does not appear in the thread. The entire transaction details appear instead
In Step 7, reply sent to paid system message in Step 6 appears in the transaction thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6504010_1717685788039.20240606_225244.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@francoisl FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[neil-marcellini]

This is not a blocker for the backend deploy. The issue was found when testing this PR, which is the cause Display send money action as paid system message in combine report. Looking at the proposal and related issue, only frontend changes where made. I'll put up a revert PR.