Repository navigation
[$250] Mention - User profile shows the old UI when clicking on user mention after sending it #43131
Description
Activity
Triggered auto assignment to @tgolen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@tgolen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsp
I'm pretty sure this problem comes from the frontend.
- changed the title
[-]Mention - User profile shows the old UI when clicking on user mention after sending it[/-][+][$250] Mention - User profile shows the old UI when clicking on user mention after sending it[/+]on Jun 5, 2024 Job added to Upwork: https://www.upwork.com/jobs/~010d3f9640b9f8d604
21 remaining items
@ShridharGoel you copied my RCA and you changed your proposal based on my comments.
@allgandalf I tested PR #42385 and this issue is totally solved. We can HOLD or close this one, I think.
Reacted by Rory AbrahamHey, I didn't have time yesterday to investigate deeply.
I think that this behavior is expected. In the design doc, we planned two separate issues for updating the
ProfilePageand then removingDetailsPage. The testing plan in this issue mentions the second case (DetailsPage) which changes hasn't been merged yet (PR).This is why the mentions shows old profile UI (because in our codebase it was actually a different component).
Reacted by Rachid L. and Gandalf- added and removed
on Jun 6, 2024 @tgolen, @allgandalf Eep! 4 days overdue now. Issues have feelings too...
Can the QA retest this ? This was fixed in another PR according to #43131 (comment)
I have asked QA to retest 👍
Not able to reproduce the issue anymore in Staging build v1.4.82-0
Reacted by JulesThank you!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.79-7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
In Step 4, user profile from mention should show the new UI
Actual Result:
In Step 4, user profile from mention should show the old UI
It shows the new UI after a while when reopening the user profile (Step 7)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6502932_1717601114418.bandicam_2024-06-05_23-20-22-036.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @allgandalf