Repository navigation
[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] Subscription size value not trim able to add spaces before the value #43069
Description
Activity
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Reacted by Christina DobrzynskiTriggered auto assignment to @tylerkaraszewski (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.Job added to Upwork: https://www.upwork.com/jobs/~0110dce96b3114bcdc
52 remaining items
- changed the title
[-][HOLD for payment 2024-06-24] [$250] Subscription size value not trim able to add spaces before the value[/-][+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] Subscription size value not trim able to add spaces before the value[/+]on Jun 21, 2024 The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-28. 🎊
For reference, here are some details about the assignees on this issue:
- @bernhardoj requires payment automatic offer (Contributor)
- @thesahindia requires payment through NewDot Manual Requests
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
- [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@thesahindia] Determine if we should create a regression test for this bug.
- [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Payouts due:
- Contributor: $250 @bernhardoj (paid in Upwork - https://www.upwork.com/nx/wm/offer/102646806)
- Contributor+: $250 @thesahindia (through NewDot)
Upwork job is here.
@thesahindia let us know about a regression test!
still have a few days till payment!
This bug was present since the implementation of this page. It was a minor issue that got missed in #42683. I don't think we need a test case for this.
Reacted by Christina DobrzynskiSounds good - no regression test for this. Thanks @thesahindia!
Awesome! Payment summary is here - #43069 (comment)
This is good to close. Feel free to reach out if I missed anything.
Reacted by Sahil$250 approved for @thesahindia
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when validating the PR #42683
Version Number: 1.4.79-2
Reproducible in staging?: y
Reproducible in production?: New feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
Spaces should not displayed with value
Actual Result:
Subscription size value not trim able to add spaces before the value
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6501964_1717527964130.2024-06-04_23-59-06.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @Christinadobrzyn