Repository navigation
[HOLD for payment 2024-06-13] Central pane padding changes when RHP is opened #43031
Description
Activity
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.@rayane-djouah @getusha this is most likely a regression from #36292 can you please confirm and handle this issue as such?
Proposal
Please re-state the problem that we are trying to solve in this issue.
Central pane padding changes when RHP is opened
What is the root cause of that problem?
We are using
shouldUseNarrowLayouthereApp/src/components/Section/index.tsx
Line 131 in 97d6d87
What changes do you think we should make in order to solve the problem?
We recently added a new update to the logic of shouldUseNarrowLayout.
We are replacing
shouldUseNarrowLayoutbyisSmallScreenWidthwhere it doesn't fits the conditions described hereWe need to use
isSmallScreenWidthhereApp/src/components/Section/index.tsx
Line 131 in 97d6d87
What alternative solutions did you explore?
Sorry about that! I think I understand the problem. useResponsiveLayout is correctly checking if there's a modal active, but it's not correctly checking that the current component is a child of that active modal. I will work on a fix for this ASAP
Here's my solution: #43074
27 remaining items
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.hey @CortneyOfstad I am OOO the rest of the week so tapping you in here. Baed on the response to my question above I think we'll need to spin up a job and pay @hoangzinh this week. Thank you!
@getusha or @hoangzinh — can you complete the checklist before EOD today so there is not a delay in payment tomorrow?
Per the SO here @getusha gets paid via NewDot, but @hoangzinh I sent you an offer via Upwork here. Please let me know once you accept so I can get this paid ASAP tomorrow.
Thanks!
@CortneyOfstad only @hoangzinh need to get paid. i wasn't involved thanks!
No worries and thank you for confirming @getusha!
- changed the title
[-][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-13] Central pane padding changes when RHP is opened[/-][+][HOLD for payment 2024-06-13] Central pane padding changes when RHP is opened[/+]on Jun 19, 2024 Hi @CortneyOfstad We don't have payment in this issue. It was still in the regression period from a PR that I reviewed. Therefore, we can close this issue.
Thanks @hoangzinh! Withdrew the proposal in Upwork and closing!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Action Performed:
Break down in numbered steps
App download linksExpected Result:
Describe what you think should've happened
No shift in styles in the central pane
Actual Result:
Describe what actually happened
Its alive, it moves
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @CortneyOfstad