Repository navigation
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Fix the style regression that removed the bold styling from the Switch component on cards #42998
Description
Activity
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Proposal
Please re-state the problem that we are trying to solve in this issue.
Revert bols style
What is the root cause of that problem?
PR should be reverted
What changes do you think we should make in order to solve the problem?
We can bring back the bold text just for these feature toggles.
App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx
Lines 201 to 212 in fe32d94
We can add props for bold text
titleStyle={styles.textStrong}only for theWorkspaceMoreFeaturesPageandWorkspaceWorkflowsPageas mentioned hereWhat alternative solutions did you explore?
- changed the title
[-]Fix the style regression that removed the bold styling from the Switch component on cards[/-][+][HOLD for payment 2024-06-18] Fix the style regression that removed the bold styling from the Switch component on cards[/+]on Jun 11, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-18. 🎊
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
- [@hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@hayata-suenaga] Determine if we should create a regression test for this bug.
- [@hayata-suenaga] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
- changed the title
[-][HOLD for payment 2024-06-18] Fix the style regression that removed the bold styling from the Switch component on cards[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Fix the style regression that removed the bold styling from the Switch component on cards[/+]on Jun 13, 2024 The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. 🎊
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
- [@hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@hayata-suenaga] Determine if we should create a regression test for this bug.
- [@hayata-suenaga] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Reacted by adelekennedyI think we're good to close here @hayata-suenaga - please reopen if I missed something!
Reacted by Hayata Suenaga
This App PR caused a styling regression.
#42596 (comment)
Bring the bold styling back to the Switch component.