[HOLD for payment 2024-06-28] [$250] Taxes - Selected tax rate for Workspace currency default can be unselected which causes error

@isabelastisser

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.77-8
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4584734
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace settings
Go to Taxes (enable it if not enabled)
Click Settings
Click Workspace currency default
Click on the selected tax rate

Expected Result:

App will not unselect the tax rate since Workspace currency default must have a tax rate

Actual Result:

The selected tax rate is unselected which results in a blank tax rate created with error "Invalid tax for default currency". The error message cannot be dismissed too
After unselecting the tax rate, the tax rate is selected again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6496493_1717088280521.20240531_005324.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f0cd7866af3328d2
Upwork Job ID: 1796250642764570624
Last Price Increase: 2024-06-06
Automatic offers:

DylanDylann | Contributor | 102691550
dominictb | Contributor | 102691783

Issue Owner

Current Issue Owner: @isabelastisser

@isabelastisser

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@isabelastisser

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Proposal

Please re-state the problem that we are trying to solve in this issue.

Taxes - Selected tax rate for Workspace currency default can be unselected which causes error

What is the root cause of that problem?

Before updating the tax we don't check if the selected tag is the same as the new selected tag.

App/src/pages/workspace/taxes/WorkspaceTaxesSettingsWorkspaceCurrency.tsx

Lines 36 to 39 in 6af6811

    
           const submit = (taxes: OptionsListUtils.TaxRatesOption) => { 
        
               setWorkspaceCurrencyDefault(policyID, taxes.code ?? ''); 
        
               Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID)); 
        
           };

App/src/pages/workspace/taxes/WorkspaceTaxesSettingsForeignCurrency.tsx

Lines 36 to 39 in 6af6811

    
           const submit = (taxes: OptionsListUtils.TaxRatesOption) => { 
        
               setForeignCurrencyDefault(policyID, taxes.code ?? ''); 
        
               Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID)); 
        
           };

What changes do you think we should make in order to solve the problem?

Only update the tax when the new selected tax is different from the previous selected tag.

        if (selectedTaxRate !== taxes.text) {
            setWorkspaceCurrencyDefault(policyID, taxes.code ?? '');
        }

Add the same in WorkspaceTaxesSettingsForeignCurrency if required.

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Selected tax rate for Workspace currency default can be unselected which causes error

What is the root cause of that problem?

We are not returning early if the tax rate is same just like we do here

App/src/libs/actions/Report.ts

Lines 1929 to 1934 in 6af6811

    
           function updateDescription(reportID: string, previousValue: string, newValue: string) { 
        
               // No change needed, navigate back 
        
               if (previousValue === newValue) { 
        
                   Navigation.goBack(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(reportID)); 
        
                   return; 
        
               }

What changes do you think we should make in order to solve the problem?

We should early return from here and here just like we do here. We can pass previousTaxCode and then compare it with new one and then we can early return from the functions.

Here we are navigating back but in the case of taxes we can just early return. No need to navigate back, we are navigating here

App/src/libs/actions/Report.ts

Lines 1929 to 1934 in 6af6811

    
           function updateDescription(reportID: string, previousValue: string, newValue: string) { 
        
               // No change needed, navigate back 
        
               if (previousValue === newValue) { 
        
                   Navigation.goBack(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(reportID)); 
        
                   return; 
        
               }

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~01f0cd7866af3328d2

@DylanDylann

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@DylanDylann

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

chore: add onDismiss handler for TaxPicker #43521

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

@DylanDylann requires payment automatic offer (Contributor)
@dominictb requires payment automatic offer (Contributor)

@DylanDylann

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@DylanDylann] Determine if we should create a regression test for this bug.
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@DylanDylann

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Go to the app
Go to workspace settings
Go to Taxes (enable it if not enabled)
Click Settings
Click Workspace currency default
Click on the selected tax rate
App will not unselect the tax rate since Workspace currency default must have a tax rate. No error happens

Do we agree 👍 or 👎

@blimpich

@blimpich, can you look at the test regression proposal above? Thanks!

The payments were processed un Upwork.

All set!

Navigation Menu

Repository navigation

[HOLD for payment 2024-06-28] [$250] Taxes - Selected tax rate for Workspace currency default can be unselected which causes error #42854

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

31 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const submit = (taxes: OptionsListUtils.TaxRatesOption) => {
	setWorkspaceCurrencyDefault(policyID, taxes.code ?? '');
	Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID));
	};

	const submit = (taxes: OptionsListUtils.TaxRatesOption) => {
	setForeignCurrencyDefault(policyID, taxes.code ?? '');
	Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID));
	};

	function updateDescription(reportID: string, previousValue: string, newValue: string) {
	// No change needed, navigate back
	if (previousValue === newValue) {
	Navigation.goBack(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(reportID));
	return;
	}

[HOLD for payment 2024-06-28] [$250] Taxes - Selected tax rate for Workspace currency default can be unselected which causes error #42854

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 30, 2024

lanitochka17 commented on May 30, 2024

lanitochka17 commented on May 30, 2024

Krishna2323 commented on May 30, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Nodebrute commented on May 30, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on May 30, 2024

melvin-bot commented on May 30, 2024

31 remaining items

melvin-bot commented on Jun 21, 2024

melvin-bot commented on Jun 21, 2024

melvin-bot commented on Jun 21, 2024

DylanDylann commented on Jun 28, 2024

isabelastisser commented on Jun 28, 2024

isabelastisser commented on Jun 29, 2024

isabelastisser commented on Jun 29, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions