Skip to content

[HOLD for payment 2024-06-13] Distance tax - Tax rate and amount rows are not updated when changing distance rate offline #42800

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.77-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #42342

Action Performed:

Precondition:

  • Track Tax distance is enabled on Old Dot.
  • Workspace has a few distance rates and tax rates
  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Open submit distance expense flow
  4. Proceed to distance expense confirmation page
  5. Click Distance rate
  6. Change distance rate
  7. Note that Tax rate and tax amount rows are updated
  8. Go offline
  9. Repeat Step 3 to 7

Expected Result:

Tax rate and tax amount rows will be updated when selecting a distance rate in offline mode

Actual Result:

Tax rate and tax amount rows are not updated when selecting a distance rate in offline mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

bandicam.2024-05-29.23-26-32-308.mp4
Issue OwnerCurrent Issue Owner: @MonilBhavsar

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on May 29, 2024
  2. melvin-bot commented on May 29, 2024

    @melvin-bot

    Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on May 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on May 29, 2024

    @lanitochka17
    Author

    @tylerkaraszewski FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. lanitochka17 commented on May 29, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Release 1

  6. MonilBhavsar commented on May 30, 2024

    @MonilBhavsar
    Contributor
  7. luacmartins commented on May 30, 2024

    @luacmartins
    Contributor

    This happens offline, so not related to Web deploy. Removing DeployBlocker label for web.

  8. self-assigned this
    on May 30, 2024
  9. MonilBhavsar commented on May 30, 2024

    @MonilBhavsar
    Contributor

    Happens offline so we're demoting from blocker

  10. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 31, 2024
  11. changed the title [-]Distance tax - Tax rate and amount rows are not updated when changing distance rate offline[/-] [+][HOLD for payment 2024-06-13] Distance tax - Tax rate and amount rows are not updated when changing distance rate offline[/+] on Jun 6, 2024
  12. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-13. 🎊

  14. MonilBhavsar commented on Jun 12, 2024

    @MonilBhavsar
    Contributor

    PR is deployed. No action is required here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions