Repository navigation
[HOLD for payment 2024-06-13] Distance tax - Tax rate and amount rows are not updated when changing distance rate offline #42800
Description
Activity
- addedDeployBlockerCashThis issue or pull request should block deploymentThis issue or pull request should block deploymentDeployBlockerIndicates it should block deploying the APIIndicates it should block deploying the API
on May 29, 2024 Triggered auto assignment to @tylerkaraszewski (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commented
on May 29, 2024 on May 29, 2024 – with GitHub ActionsContributorMore actions👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@tylerkaraszewski FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #wave-collect - Release 1
cc @narefyev91
This happens offline, so not related to Web deploy. Removing
DeployBlockerlabel for web.Reacted by Monil Bhavsar- removedDeployBlockerIndicates it should block deploying the APIIndicates it should block deploying the API
on May 30, 2024 - removedDeployBlockerCashThis issue or pull request should block deploymentThis issue or pull request should block deployment
on May 30, 2024 Happens offline so we're demoting from blocker
- addedReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionand removedDailyKSv2KSv2WeeklyKSv2KSv2
on May 31, 2024 - changed the title
[-]Distance tax - Tax rate and amount rows are not updated when changing distance rate offline[/-][+][HOLD for payment 2024-06-13] Distance tax - Tax rate and amount rows are not updated when changing distance rate offline[/+]on Jun 6, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-13. 🎊
PR is deployed. No action is required here
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.77-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #42342
Action Performed:
Precondition:
Expected Result:
Tax rate and tax amount rows will be updated when selecting a distance rate in offline mode
Actual Result:
Tax rate and tax amount rows are not updated when selecting a distance rate in offline mode
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
bandicam.2024-05-29.23-26-32-308.mp4
Issue Owner
Current Issue Owner: @MonilBhavsar