Repository navigation
[$250] Android-Room-After creating room, entering @ not showing contact suggestions #42766
Description
Activity
Triggered auto assignment to @bondydaa (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsb
25 remaining items
There were no Android-specific changes between
react-native-live-markdown@0.1.70and0.1.76so I have no idea what could have caused this regression.edit: I've bumped Live Markdown to 0.1.76 and I cannot reproduce the original problem with suggestion box, it works for me.
I quote Skalakid comment.
After a quick investigation I found out that the live markdown parser is using a different commit of expensify-common than E/App. Live Markdown parser uses a newer version of ExpeniMark that contains changes that block blockquote creation without space after
I will create PR that bumps the version in the Expensify App
I pulled the latest main and E/App has a newer version of expensify-common than live markdown. I can't reproduce this issue nowMaybe with the latest version of expensify-common and react-native-live-markdown the issue will not reproduce anymore. I will verify this on Monday (unluckily now I have other commitments). Thanks
Reacted by Tomasz Zawadzki and David Bondy@bondydaa, @jliexpensify, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!
Thanks @tomekzaw and @fabOnReact let me know if you need anything from me.
I tested and I can not reproduce this issue anymore.
CLICK TO OPEN TESTS RESULTS
Screen.Recording.2024-06-11.at.11.59.08.AM.mov
CLICK TO OPEN TESTS RESULTS
Reacted by David Bondy@jliexpensify Can we release bounty for the issue please
@bondydaa, @jliexpensify, @ishpaul777 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
There wasn't an actual regression here right? Also, what's the original PR? Melvin hasn't updated the date so just want to check everything has been deployed.
@bondydaa @jliexpensify @ishpaul777 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
PR - #42843
Will pay out today, confirmed with Bondy no checklist needed. Payment summary.
Paid and job closed.
Reacted by Fabrizio Bertoglio
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.77-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4585586
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
After creating room, entering @ must show contact suggestions
Actual Result:
After creating room, entering @ not showing contact suggestions but shown on revisit.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6495138_1716990722444.Screenrecorder-2024-05-29-19-16-06-795_compress_1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @jliexpensify