Repository navigation
[HOLD for payment 2024-06-13] [LOW] [Performance] Improve AppNavigator Performance #42744
Description
Activity
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.
Reacted by JulesJob added to Upwork: https://www.upwork.com/jobs/~01ec3bf0fc8d2fa2f1
- changed the title
[-][LOW] [Performance] Improve AppNavigator Performance[/-][+][$250] [LOW] [Performance] Improve AppNavigator Performance[/+]on May 29, 2024 Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (
External)14 remaining items
- changed the title
[-][LOW] [Performance] Improve AppNavigator Performance[/-][+][HOLD for payment 2024-06-13] [LOW] [Performance] Improve AppNavigator Performance[/+]on Jun 6, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-13. 🎊
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@c3024] The PR that introduced the bug has been identified. Link to the PR:
- [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@c3024] Determine if we should create a regression test for this bug.
- [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
To prepare for the payment date, @c3024 please accept the invite here: https://www.upwork.com/jobs/~01ec3bf0fc8d2fa2f1. Tomorrow, I'll complete the payment process in Upwork. Thanks!
@alexpensify Thanks, accepted the invite.
Payment Summary
- Contributor: @rezkiy37 is from an agency-contributor and not due payment
- ROLE: @c3024 paid $(AMOUNT) via Upwork (LINK)
BugZero Checklist (@alexpensify)
- I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1795785815695171584/hired)
- I have paid out the Upwork contracts or cancelled the ones that are incorrect
- I have verified the payment summary above is correct
Metadata
Metadata
Labels
Type
Projects
- Status
Coming from here. @rezkiy37
Problem
There is a core component of the app - AppNavigator. Basically, it renders AuthScreens or PublicScreens based on a prop - authenticated. Currently, the component takes around 250ms to render. Also, it re-renders several times.
Solution
I propose to decrease the render duration and avoid redundant re-renders.
Wrap the component in React.memo to get a memoized version of that component. And, as a result, AppNavigator renders once and does not re-render anymore until the user logins/logouts (authenticated changed). PublicScreens renders once as well.
There is a commit here. I am attaching screenshots with the legacy (the 1st) and updated (the 2nd) versions.
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @alexpensify