Repository navigation
[HOLD for payment 2024-06-28] Disabling Delayed Submission in NewDot turns off Scheduled Submit instead of setting Instant Submit #42685
Description
Activity
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Can the App PR come off hold here?
- moved this from HOT PICKS to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect
on Jun 4, 2024 I was C+ on the PR. Please assign me.
5 remaining items
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-28. 🎊
For reference, here are some details about the assignees on this issue:
- @parasharrajat requires payment through NewDot Manual Requests
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
- [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@parasharrajat] Determine if we should create a regression test for this bug.
- [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: It is refactor.
- [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
- [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
- [@parasharrajat] Determine if we should create a regression test for this bug. YES
- [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
- Create new workspace in NewDot
- Disable Delayed Submission
- Workspace has Scheduled Submit enabled and 'Instantly' selected, on OldDot.
Do you agree 👍 or 👎 ?
Reacted by adelekennedyPayment Summary
- Reviewer: @parasharrajat owed $250 via NewDot
BugZero Checklist (@adelekennedy)
- I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
- I have paid out the Upwork contracts or cancelled the ones that are incorrect
- I have verified the payment summary above is correct
payment summary is correct, payments due:
$250 @parasharrajat (NewDot)
Payment requested as per #42685 (comment)
- moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect
on Jul 1, 2024 $250 approved for @parasharrajat
Action Performed:
Expected Result:
Workspace has Scheduled Submit enabled and 'Instantly' selected.
Actual Result:
Workspace has Scheduled Submit disabled.
Workaround:
Set 'Instantly' in OldDot, no workaround in NewDot.
Platform:
All
cc @lakchote @Beamanator
Issue Owner
Current Issue Owner: @adelekennedy