Skip to content

[HOLD for payment 2024-06-13] [Xero] [QBO] Inconsistencies with Add and Delete actions after disconnecting Xero or QBO #42565

Closed

Description

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:@trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1716500227496579?thread_ts=1716238514.357639&cid=C036QM0SLJK

Action Performed:

  1. Create a workspace
  2. Connect to Xero
  3. Enable Taxes
  4. Sync the integration
  5. Verify Categories, Tags and Taxes are enabled and there are menu items for each in the LHN of the workspace settings
  6. Click into each of Categories, Tags and Taxes pages
  7. Verify you can't Add or Delete a value manually
  8. Disconnect from Xero
  9. Click into each of Categories, Tags and Taxes pages
  10. Observe the inconsistencies detailed in the "Actual results" section below
  11. Repeat the steps above but this time for QBO
  12. Refresh & sign-in/sign-out to verify there's no change and the bug is still present

Note: I've been using the latest Xero feature branch to test.

Expected Result:

After disconnecting from QBO or Xero you should be able to manually add or delete categories, tags and taxes.

Actual Result:

After disconnecting from Xero and QBO:

Xero
Can’t add categories (❌), but can delete them (✅).
Can’t add or delete tax rates (❌).
Can add or delete tags (✅).

QBO
Can’t add categories (❌), but can delete them (✅).
Can’t add or delete tax rates (❌).
Can add or delete tags (✅).

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
None

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2024-05-23_22-26-48.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 23, 2024
  2. melvin-bot commented on May 23, 2024

    @melvin-bot

    Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

  3. moved this to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collecton May 23, 2024
  4. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 24, 2024
  5. changed the title [-][Xero] [QBO] Inconsistencies with Add and Delete actions after disconnecting Xero or QBO[/-] [+][HOLD for payment 2024-06-13] [Xero] [QBO] Inconsistencies with Add and Delete actions after disconnecting Xero or QBO[/+] on Jun 6, 2024
  6. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  7. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-13. 🎊

  8. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
    • [@hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@hayata-suenaga] Determine if we should create a regression test for this bug.
    • [@hayata-suenaga] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  9. trjExpensify commented on Jun 13, 2024

    @trjExpensify
    ContributorAuthor

    Regression test won't be required here, @zanyrenney is adding them centrally for the Xero project.

    Payment summary as follows:

    Aimane, feel free to send a new dot request!

    Closing! :)

  10. moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collecton Jun 13, 2024
  11. aimane-chnaif commented on Oct 3, 2024

    @aimane-chnaif
    Contributor

    @trjExpensify I am still using upwork. Can you please reopen and sort payment? Thanks

  12. trjExpensify commented on Oct 8, 2024

    @trjExpensify
    ContributorAuthor

    Offer for $250 has been sent in Upwork.

  13. trjExpensify commented on Oct 17, 2024

    @trjExpensify
    ContributorAuthor

    Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions