Repository navigation
[HOLD for payment 2024-08-02] [$250] Video - Change in playback speed is not reflected in thread report #42519
Description
Activity
Triggered auto assignment to @Julesssss (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
- If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
- If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
- Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
- You can adjust the urgency of the issue to better represent the gravity of the bug.
- If the issue is super low priority, feel free to un-assign yourself.
- Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
- If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
- If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
We think that this bug might be related to #vip-vsp
@Julesssss FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Thanks.
This should not block deploy IMO. Removing the label.
93 remaining items
The PR is ready for review cc @Julesssss @situchan
There was bug on that deploy. Melvin didn't post deploy comment on all PRs in this checklist.
cc: @BeamanatorAgreed 👍 I posted in the PR about it being deployed to prod here - #46800 (comment)
- The PR that introduced the bug has been identified. Link to the PR: Playback speed is not displayed correctly in video player #40646 #41055
- The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/41055/files#r1725293900
- A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Regression Test Steps
- Send a video to any chat
- Reply the video in thread
- Navigate to parent report
- Change playback speed
- Navigate to thread
- Open playback speed menu
- Verify thread's playback speed is the same with parent's
Thanks @situchan
Test Case GH created@tienifr paid $250 via NewDot
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.75-0
Reproducible in staging?: Y
Reproducible in production?: N
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Changes in Playback speed from the main report should be reflected in the thread report
Actual Result:
Changes in playback speed from the main report is not reflected in the thread report
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6489315_1716463467872.Screen_Recording_2024-05-23_at_12.41.26_in_the_afternoon.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @situchan