Repository navigation
[$250] [Payment card / Subscription] Add SCA support in Transfer Owner flow #42490
Description
Per this discussion in the Payment card and subscription management in NewDot design doc, we need to support adding a GBP payment card in the "Transfer Owner" flow.
To test
- As the owner of a Collect policy, add a new admin
- Log into NewDot as that admin
- Navigate to Account Settings > Workspaces > [workspace] > Members > click on the row of the current owner > Transfer Owner
Currently, when transferring ownership of a policy in NewDot, the AddBillingCardAndRequestPolicyOwnerChange API command is called. That command is calling UserAPI::addPaymentCard, which doesn't account for “Strong Customer Authentication” aka SCA requirements (which are relevant for GBP-currency payment cards).
Once SCA support is built out for NewDot in the Payment card project, we should use it as a base to extend to the Transfer Owner flow.
Update September 5th 2024
SCA support is now in new dot but making SCA possible for the transfer owner flow has required doing a lot of backend work to make it follow our 1:1:1 rule where 1 action equals with call to the web layer which equals one call to the Auth layer.
Once both of these PRs are merge though (1, 2) then this issue should be unblocked. From there we should follow the plan outlined in this comment to use the new VerifySetupIntentAndRequestPolicyOwnerChange command to complete the SCA transfer owner flow.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021832164283072592668
- Upwork Job ID: 1832164283072592668
- Last Price Increase: 2024-09-06
Activity
[-][HOLD Payment card / Subscription project] Add SCA support in Transfer Owner flow[/-][+][HOLD] [Payment card / Subscription] Add SCA support in Transfer Owner flow[/+][-][HOLD] [Payment card / Subscription] Add SCA support in Transfer Owner flow[/-][+][HOLD #42432] [Payment card / Subscription] Add SCA support in Transfer Owner flow[/+]blimpich commentedon Jul 18, 2024
Still waiting for SCA to work in the subscription page, making progress.
[-][HOLD #42432] [Payment card / Subscription] Add SCA support in Transfer Owner flow[/-][+][Payment card / Subscription] Add SCA support in Transfer Owner flow[/+]79 remaining items
blimpich commentedon Sep 25, 2024
@DylanDylann I'm signing off for the day but are you going to be able to review this tomorrow during my work hours (9am-5pm PST)? I'd like to keep the ball rolling on this PR. Thank you!
DylanDylann commentedon Oct 14, 2024
@JmillsExpensify The PR is deployed to production on 2/10. The payment should be ready on 9/10
JmillsExpensify commentedon Oct 16, 2024
Ah sorry about that.
Payment summary: $250 for @DylanDylann for PR review and testing. Payment via Upwork.
JmillsExpensify commentedon Oct 16, 2024
All paid out.