Repository navigation
[HOLD for payment 2024-06-11] [Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't enable Taxes by default #42466
Description
Activity
- moved this to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect
on May 22, 2024 - changed the title
[-][Wave Collect] [Xero] Disable Taxes when disconnecting[/-][+][Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't support it[/+]on May 22, 2024 - changed the title
[-][Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't support it[/-][+][Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't enable Taxes by default[/+]on May 22, 2024 @trjExpensify based on the comment this was not fully fixed, I think we need to find someone to look into this / retest and fix if its not done yet #42467 (comment)
Cool, I can retest after the next deploy.
24 remaining items
#42466 (comment)
I found the culprit, and pushed a PR to fix it here
cc @trjExpensify once you'll see why we weren't seeing the bug... ah 😄
Dang, nice sleuthing!
Issue is reproducible during KI retests.
Comment for assignment
assigned @allroundexperts since they're helping to test the PR #44952
The regression period is over on this. Confirming payment summary as follows:
- $250 to @allroundexperts for the C+ review
Go ahead and request! Closing.
- moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collect
on Jul 24, 2024 $250 approved for @allroundexperts
We need to remove
Taxesfrom the LHN when we're disconnecting from Xero and we had taxes sync enabled.