[HOLD for payment 2024-06-13] [LOW] [Performance] Add no-spread-in-reduce to avoid recreating array in reduce method

@kacper-mikolajczak

Problem

When you use the spread operator in an array reduce, it often leads to a partial object being copied over and over again in a loop.

// BAD
const reducedObject = myArray.reduce(
    (acc, key) => ({
        ...acc,
        [key]: someOtherObject[key],
    }),
    {},
);

Especially with large objects, this is very inefficient because ...acc will unnecessarily copy the full object on each iteration, rather than just adding the single key we want to add.

Solution

Prohibit this pattern with a new ESLint rule - no-spread-in-reduce. The above example would result in a lint error, and you might fix it with something more simple and efficient, like this:

GOOD
const reducedObject = myArray.reduce(
    (acc, key) => {
        acc[key] = someOtherObject[key];
        return acc;
    },
    {},
)

@kacper-mikolajczak

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011102640f041d624c
Upwork Job ID: 1792878366584131584
Last Price Increase: 2024-05-21
Automatic offers:

DylanDylann | Reviewer | 0

Issue Owner

Current Issue Owner: @garrettmknight

@garrettmknight

Triggered auto assignment to @garrettmknight (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

Job added to Upwork: https://www.upwork.com/jobs/~011102640f041d624c

@DylanDylann

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@kacper-mikolajczak

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Chore: Update eslint-config-expensify to 2.0.49 #42650

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

@kacper-mikolajczak does not require payment (Contractor)
@DylanDylann requires payment automatic offer (Reviewer)

@DylanDylann

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@DylanDylann

@DylanDylann you've been paid out - no regression test for this one.

Navigation Menu

Repository navigation

[HOLD for payment 2024-06-13] [LOW] [Performance] Add no-spread-in-reduce to avoid recreating array in reduce method #42414

Problem

Solution

14 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-06-13] [LOW] [Performance] Add no-spread-in-reduce to avoid recreating array in reduce method #42414

Description

Problem

Solution

Activity

melvin-bot commented on May 21, 2024

melvin-bot commented on May 21, 2024

melvin-bot commented on May 21, 2024

14 remaining items

melvin-bot commented on Jun 6, 2024

melvin-bot commented on Jun 6, 2024

melvin-bot commented on Jun 6, 2024

garrettmknight commented on Jun 13, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions