Repository navigation
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] [Wave Control - NetSuite] Have Accounting Connection Sync Spinner Timeout After 20 minutes #42356
Description
Activity
- changed the title
[-]Have Accounting Connection Sync Spinner Timeout After 20 minutes.[/-][+]Have Accounting Connection Sync Spinner Timeout After 20 minutes[/+]on May 17, 2024 Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.- changed the title
[-]Have Accounting Connection Sync Spinner Timeout After 20 minutes[/-][+][Wave Control - NetSuite] Have Accounting Connection Sync Spinner Timeout After 20 minutes[/+]on May 17, 2024 I think this is
New Feature, notBugright?37 remaining items
Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-18. 🎊
For reference, here are some details about the assignees on this issue:
- @ahmedGaber93 requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@ahmedGaber93] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
- [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
- changed the title
[-][HOLD for payment 2024-06-18] [$250] [Wave Control - NetSuite] Have Accounting Connection Sync Spinner Timeout After 20 minutes[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] [Wave Control - NetSuite] Have Accounting Connection Sync Spinner Timeout After 20 minutes[/+]on Jun 13, 2024 The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. 🎊
For reference, here are some details about the assignees on this issue:
- @ahmedGaber93 requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@ahmedGaber93] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
- [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Payment Summary:
- @ahmedGaber93 paid $250 here (C+)
NewFeature, not sure we need a regression test right?
- moved this from Release 2: Summer 2024 (Aug) to Done in #expensify-bugs
on Jun 20, 2024 @twisterdotcom offer accepted, please please complete the payment when you are available. Thanks!
Reacted by Ted Harris
Metadata
Metadata
Assignees
Labels
Type
Projects
- Status
Part of the #Wave-Control NetSuite project
Main issue: https://github.com/Expensify/Expensify/issues/377671
Doc section: https://docs.google.com/document/d/1WubNv_VAv78IxG4FKsi9aS0pWESfWvUYbqBAAy5b4bc/edit#heading=h.tb9yro1dmj3r
Project: #expensify-bugs
Feature Description
One issue with the Pusher ProgressManager updates for syncs that come from the IS to NewDot is that they are sometimes unreliable. If the
jobDonesync update is not received by the client, then the sync spinner will hang forever, even though the sync has finished:Kapture.2024-05-17.at.15.00.36.mp4
To fix this, let's have the spinner timeout to stop 20 min after a sync is started and no
jobDonesync update is received. We landed one 20 minutes because, in recent measurements, our longest NetSuite jobs take around 14 minutes.Manual Test Steps
Automated Tests
N/A
cc @aldo-expensify @francoisl @lakchote @marcaaron @tgolen
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @twisterdotcom