Skip to content

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$125] [TS migration] Configure TS & Migrate CONST, fastMerge, Device, Logger to Typescript (expensify-common) #42245

Closed
Closed
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$125] [TS migration] Configure TS & Migrate CONST, fastMerge, Device, Logger to Typescript (expensify-common)#42245
Assignees
bfitzexpensifyblazejkustraabdulrahuman5196roryabrahamjoekaufmanexpensify
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewTypescript Migration

Description

@blazejkustra
blazejkustra
opened on May 16, 2024

Typescript migration (expensify-common)

Make sure you read through our TypeScript's style guide before you start working on this migration issue.

Files

lib/CONST.jsx
lib/fastMerge.js
lib/Device.jsx
lib/Logger.jsx

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a5172255327c6e67
  • Upwork Job ID: 1791118677164871680
  • Last Price Increase: 2024-05-16

Activity

  1. blazejkustra
    added
    BugSomething is broken. Auto assigns a BugZero manager.
    DailyKSv2
    on May 16, 2024
  2. melvin-bot
    assigned
    joekaufmanexpensify
    on May 16, 2024

  3. melvin-bot commented on May 16, 2024

    @melvin-bot
    melvin-botbot
    on May 16, 2024 – with Melvin Bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. blazejkustra commented on May 16, 2024

    @blazejkustra
    blazejkustra
    on May 16, 2024
    ContributorAuthor

    I got approval from @roryabraham to create this issue on #typescript-new-expensify channel here. Let's add it to Typescript project and change labels as this is not a bug, thanks!

  5. blazejkustra commented on May 16, 2024

    @blazejkustra
    blazejkustra
    on May 16, 2024
    ContributorAuthor

    I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue 😄

  6. joekaufmanexpensify
    added this to Typescript migrationon May 16, 2024
  7. joekaufmanexpensify
    added
    Typescript Migration
    WeeklyKSv2
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    DailyKSv2
    on May 16, 2024
  8. melvin-bot
    changed the title [-][TS migration] Configure TS & Migrate `CONST`, `fastMerge`, `Device`, `Logger` to Typescript (expensify-common)[/-] [+][$250] [TS migration] Configure TS & Migrate `CONST`, `fastMerge`, `Device`, `Logger` to Typescript (expensify-common)[/+] on May 16, 2024

  9. melvin-bot commented on May 16, 2024

    @melvin-bot
    melvin-botbot
    on May 16, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~01a5172255327c6e67

  10. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 16, 2024

  11. 60 remaining items

  12. joekaufmanexpensify commented on Jun 14, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Jun 14, 2024
    Contributor

    There may be a possible regression here too. @roryabraham @abdulrahuman5196 could you please confirm if this was indeed a regression?

  13. joekaufmanexpensify commented on Jun 14, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Jun 14, 2024
    Contributor

    I'm about to go OOO until 2024-06-25. Adding another BZ assignee to handle payment next week. We just need to:

    • Determine whether this was a regression.
    • Issue payment after the waiting period.

    I'll take this back once I return (if it's still open)!

  14. joekaufmanexpensify
    removed their assignment
    on Jun 14, 2024
  15. joekaufmanexpensify
    added
    NewFeatureSomething to build that is a new item.
    and removed
    NewFeatureSomething to build that is a new item.
    on Jun 14, 2024
  16. melvin-bot
    assigned
    bfitzexpensify
    on Jun 14, 2024

  17. melvin-bot commented on Jun 14, 2024

    @melvin-bot
    melvin-botbot
    on Jun 14, 2024 – with Melvin Bot

    Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  18. joekaufmanexpensify
    self-assigned this
    on Jun 14, 2024
  19. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Jun 18, 2024

  20. bfitzexpensify commented on Jun 20, 2024

    @bfitzexpensify
    bfitzexpensify
    on Jun 20, 2024
    Contributor

    Bump on #42245 (comment) @roryabraham @abdulrahuman5196 - thank you!

  21. abdulrahuman5196 commented on Jun 20, 2024

    @abdulrahuman5196
    abdulrahuman5196
    on Jun 20, 2024
    Contributor

    @bfitzexpensify I don't think this is a direct regression but a combined issue due to efforts from different PR.
    But feel free to correct me if wrong.

  22. melvin-bot commented on Jun 20, 2024

    @melvin-bot
    melvin-botbot
    on Jun 20, 2024 – with Melvin Bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@bfitzexpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1791118677164871680/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct

  23. bfitzexpensify commented on Jun 24, 2024

    @bfitzexpensify
    bfitzexpensify
    on Jun 24, 2024
    Contributor

    Thanks for confirming @abdulrahuman5196. Paid out, we're all done here.

  24. bfitzexpensify
    closed this as completedon Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewTypescript Migration

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions