Repository navigation
Unread indicator doesn't clear if you are in the room that a new comment is posted in #42
Description
Activity
this is fixed
Hm, I'm not totally convinced it is, I'd love to test this in production with someone to verify that it's fixed. Marking CRITICAL because we are going to be promoting this as a rock-solid solution, so reliability is key.
Looking for issues to demote, this doesn't seem as critical as the others, reducing to HIGH
I had issues with this working well this morning with a ton of unread chats
Huh, odd... it seems to just always work for me. Hopefully, we can find a way to reproduce it or capture what's actually happening.
Ya, I can't reproduce this one. This is what I tried:
- Open up #react-ion room in my main browser window (dbarrett@expensify.com), and incognito window (dbarrett@quinthar.com)
- In the main window, pick a different tab (so ChatDot isn't in the foreground)
- Comment in the incognito window, comment in the room
- I correctly see that there is an unread comment in the tab
- When I switch to the tab, it immediately marks the unread comment as read
- The LHN correctly shows there is nothing unread
Same steps work if the "main window" is replaced with the Android app (though Pusher still seems kinda flaky to me -- it's not 100% reliable about sending new actions to the open report, but I think that's a different issue). I'm going to close this until someone can provide reproduction steps.
- added a commit that references this issue
on Feb 1, 2024 - added a commit that references this issue
on Mar 30, 2026 Hi @tgolen. Do we need to QA this?
No, this is a super old PR and was incorrectly linked
Reacted by IuliiaHerets🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.51-10 🚀
platform result 🕸 web 🕸 success ✅ 🤖 android 🤖 failure ❌ 🍎 iOS 🍎 success ✅
