Repository navigation
[HOLD for payment 2024-06-11] [$250] Chat - Emoji is deleted if entered quickly after some text #41778
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.71-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4544514
Email or phone of affected tester (no customers): vdargentotest+ios050724@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Pre-requisite: user must be logged in.
- Go to any chat.
- Tap on the compose box.
- Enter any text but do not send the message.
- Tap on the emoji picker and quickly select any emoji. (Note: don't add a space between the word and the emoji)
- Verify it appears for a moment on the compose box, but suddenly disappears.
Expected Result:
The selected emoji should remain on the compose box.
Actual Result:
The selected emoji is displayed for a moment, but suddenly disappears.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6473896_1715096211593.Tjqj0461_1_.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01f96963f235e9c546
- Upwork Job ID: 1787904276326506496
- Last Price Increase: 2024-05-07
- Automatic offers:
- hungvu193 | Reviewer | 0
Activity
melvin-bot commentedon May 7, 2024
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.izarutskaya commentedon May 7, 2024
We think this issue might be related to the #vip-vsb.
trjExpensify commentedon May 7, 2024
I can reproduce this. You have to add the emoji to the end of the text with no space for it to disappear.
[-]Chat - Emoji is deleted if entered quickly after some text[/-][+][$250] Chat - Emoji is deleted if entered quickly after some text[/+]melvin-bot commentedon May 7, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01f96963f235e9c546
melvin-bot commentedon May 7, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (
External)roitman-g commentedon May 9, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
When you enter some text (it can also be space in the end) and then insert an emoji in less than a second after finishing typing, the emoji is being removed. This also can be reproduced in any other platform, just be quick.
What is the root cause of that problem?
In "ComposerWithSuggestions" component "updateComment" function a comment update with regular text is saved with the debounced function, while comment update with emoji is not. So what happens is first the comment with the emoji is being saved and then the debounced function is being invoked with the old value, reverting the comment to the previous non-emoji state.
What changes do you think we should make in order to solve the problem?
There are two way to solve this issue.
debouncedSaveReportComment.flush()line of code when updating the comment with the emoji in "updateComment" function. This will invoke the debounced function before the emoji insertion.updateComment(ComposerUtils.insertText(commentRef.current, selection, text), true);in "replaceSelectionWithText" function. This will update the debounced function and invoke it with the correct value.What alternative solutions did you explore? (Optional)
N/A
melvin-bot commentedon May 10, 2024
@trjExpensify, @hungvu193 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
35 remaining items
hungvu193 commentedon Jun 11, 2024
Regression test:
Do we 👍 or 👎 ?
trjExpensify commentedon Jun 11, 2024
Thanks, @hungvu193! I don't think we need a standalone regression test for this, it was caught while executing an existing one as per the OP link.
Payment summary as follows:
Hans is paid. @roitman-g, can you send me your Upwork profile please?
hungvu193 commentedon Jun 11, 2024
@trjExpensify can you check upwork again? I think contract was ended without payment
roitman-g commentedon Jun 12, 2024
May I use this upwork account for this - https://www.upwork.com/freelancers/~0197cfa7f554b66970?
trjExpensify commentedon Jun 13, 2024
@hungvu193 looks paid to me:
Yeah @roitman-g, if that's your Upwork profile? 😕
iwiznia commentedon Jun 17, 2024
Anything else to do here?
trjExpensify commentedon Jun 18, 2024
@roitman-g can you confirm on this?
roitman-g commentedon Jun 19, 2024
It is not mine, it is my brother's, I need to prepare my documents to verify my upwork. If it needs to be my upwork, can I send it in the next two weeks?
trjExpensify commentedon Jun 19, 2024
Sounds good, @roitman-g. I've sent an offer to that Upwork profile. Please accept and then I'll pay and close this issue out.
trjExpensify commentedon Jun 20, 2024
Paid, closing!