[HOLD for payment 2024-05-20] Split scan - Split preview does not show individual split amount under "Split amounts" list

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.71-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to group chat.
3. Go to + > Split expense.
4. Go to Scan.
5. Upload a receipt.
6. Split the expense.
7. Click on the split preview.
8. Enter amount.
9. Split the expense.
10. Click on the split preview.

Expected Result:

The split preview will show individual split amount under "Split amounts" list.

Actual Result:

The split preview does not show individual split amount under "Split amounts" list.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6473655_1715080219392.split_scan_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019be40158dc575160
• Upwork Job ID: 1787967813100097536
• Last Price Increase: 2024-05-07

Issue Owner

Current Issue Owner: @miljakljajic

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[miljakljajic]

@flodnv what do you think - is this actually a DB? I know you're working on the fire right now

[m-natarajan]

@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think this bug might be related to #vip-split

[nexarvo]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split preview does not show individual split amount under "Split amounts" list

What is the root cause of that problem?

We are not getting amount in transaction.comment.splits:

And we only checking if we don't have splits then calculate amount here:

App/src/components/MoneyRequestConfirmationList.tsx

Line 476 in 222419b

isPolicyExpenseChat || !transaction?.comment?.splits

What changes do you think we should make in order to solve the problem?

We can update the condition to check if we have amount in the split or not and if we don't have amount then calculate the amount like this:

if (iouAmount > 0) {
+    const splitAmount = transaction.comment.splits.find((split) => split.accountID === participantOption.accountID)?.amount ?? null;

    amount =
-        isPolicyExpenseChat || !transaction?.comment?.splits
+        isPolicyExpenseChat || !transaction?.comment?.splits || !splitAmount
            ? IOUUtils.calculateAmount(selectedParticipants.length, iouAmount, iouCurrencyCode ?? '', isPayer)
-            transaction.comment.splits.find((split) => split.accountID === participantOption.accountID)?.amount
+            : splitAmount;

}

Note

In the suggested code I have created splitAmount variable to be re-used. We can also refactor this in PR step.

What alternative solutions did you explore? (Optional)

Result

Screen.Recording.2024-05-07.at.7.18.48.PM.mov