[HOLD for payment 2024-06-06] [$250] Wrong "Next step" displayed for the approver

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.70-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714518611299619

Action Performed:

Prerequisite: Have a collect workspace with admin, approver, and employee.

1. Employee submits report to approver
2. Approver approves the report
3. Observe the next step header for approver

Expected Result:

"Waiting for you to pay these expenses" should not be displayed for the approver

Actual Result:

"Waiting for you to pay these expenses" is displayed for approver who is not configured to pay the report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

pay.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e9b6cf8e506af2ea
• Upwork Job ID: 1787692015561465856
• Last Price Increase: 2024-05-07
• Automatic offers:
• dukenv0307 | Reviewer | 0

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Payer is wrong in the header

What is the root cause of that problem?

When an employee creates a money request, the backend returns a request report where the managerID is the ID of the approver

App/src/libs/NextStepUtils.ts

Lines 302 to 309 in 2f5173c

	if (!isOwner) {
	optimisticNextStep.message = [
	{
	text: 'Waiting for ',
	},
	{
	text: managerDisplayName,
	type: 'strong',

Given that managerDisplayName is "you"

If I understand correctly:

• ownerID corresponds to the ID of the request creator
• managerID corresponds to the ID of the workspace admin

If this understanding is accurate, then the current logic here is wrong

What changes do you think we should make in order to solve the problem?

We need to extract the approverID from the policy using approverID = policy.submitsTo. Then

• If the current user is the approver, we'll show "you"
• If the current user isn't the approver, we'll display the name of the approver

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e9b6cf8e506af2ea

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)