Skip to content

[HOLD for payment 2024-06-05] [HOLD for payment 2024-05-22] [QBO] Implement support for importing more than one of Classes, Customers/Projects or Locations on the tags page #41279

Description

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.68-0
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714438462878199?thread_ts=1714400674.229349&cid=C036QM0SLJK

Action Performed:

  1. Create a workspace on NewDot
  2. Go to More Features > Tags > Enable (you need this step for now because otherwise Tags won't show in the LHN after you connect to QBO to see the imported coding, apparently that's going to be worked on https://github.com/Expensify/Expensify/issues/387834#issuecomment-2083773292)
  3. Connect to QBO
  4. Go to Import
  5. Check both Classes and Customers/Projects are Imported, displayed as tags (should be the default like OldDot for now)
  6. Go to the Tags page in the LHN
  7. Observe only the values for Classes are shown on the page

Expected Result:

  1. When more than one of Classes, Customers/Projectsor Locations are selected for import, the Tags page table will represent each distinct tag level imported from QBO
  2. If the tag level is required, Required will be added to the status column in the table instead of Enabled || Disabled`
image
  1. Behind the "Settings" button on the Tags page header in the RHP:
    3a. the toggle for "Members must tag all spend" will remain, allowing users to bulk toggle on/off making all tag levels mandatory.
    3b. the Custom tag name field will be removed; users will be able to set the Custom tag name a level deeper for each of the tag levels (see 4b. below)

image

  1. Clicking on a tag level name in the table will open the RHP, which will contain:
    4a. A required toggle, when enabled it makes the tag level required coding on the workspace and sets Required in the main Tags page table
    4b. A Custom tag name > push input row, that opens a simple "Custom tag name" page with a text input to rename the tag level.
image

4c. A list of all of the tag values for that tag level (that opens up the individual tag value edit page with the same permissions and logic that exists today).

image

4d. checkboxes right-aligned each of the tag values to facilitate bulk select capabilities via the [Selected X v] button with the same permissions and logic that exists today.
image

Actual Result:

Only the first level of tag is shown in the Tags page table, additional levels imported are ignored.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
None

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

See expected results for the intended solution. Below is today:

image image

View all open jobs on GitHub

CC: @hayata-suenaga @aldo-expensify @zanyrenney @narefyev91 @teneeto

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions