[HOLD for payment 2024-06-03] [$250] Task - Deleted #admins room displayed in share somewhere when creating task

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4516164
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Open the app and log in
2. Create a workspace
3. Add some message to #admins room
4. Tap FAB > Assign task
5. Create a task and share in the #admins room
6. Delete the workspace
7. Tap FAB > Assign task
8. Open Share somewhere on the task confirmation screen

Expected Result:

#Admins room from the deleted workspace is not displayed

Actual Result:

#Admins room from the deleted workspace is displayed and can be selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6462182_1714084057568.video_2024-04-25_15-14-58.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0190dd051f8a814833
• Upwork Job ID: 1784888107450617856
• Last Price Increase: 2024-04-29
• Automatic offers:
• c3024 | Contributor | 0
• tienifr | Contributor | 0

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

#Admins room from the deleted workspace is displayed and can be selected

What is the root cause of that problem?

We're using useOptionsList hook to get optionList

When reports change we update the optionList in

App/src/components/OptionListContextProvider.tsx

Lines 50 to 53 in e280478

	/**
	* This effect is used to update the options list when a report is updated.
	*/
	useEffect(() => {

But we just get the last updated report

App/src/components/OptionListContextProvider.tsx

Line 59 in e280478

const lastUpdatedReport = ReportUtils.getLastUpdatedReport();

In this case it's not correct since when users delete WS, 3 reports are updated (chat, admin, announce) -> just only chat is updated

What changes do you think we should make in order to solve the problem?

We should not update the last updated report because of the above reason, instead of that we can do the same with personalDetails

App/src/components/OptionListContextProvider.tsx

Line 114 in e280478

const newPersonalDetailsOptions = OptionsListUtils.createOptionList(personalDetails).personalDetails;

        const newReports = OptionsListUtils.createOptionList({}, reports).reports;

        setOptions((prevOptions) => {
            const newOptions = {...prevOptions};
            newOptions.reports = newReports
            return newOptions;
        });

To improve the performance, we can compare the newReports with the current reports before decide to update them

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0190dd051f8a814833

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)