Skip to content

[HOLD for payment 2024-06-03] [QBO] Not all default settings & accounts are selected when establishing the connection to QBO #41046

Description

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.66-1
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714060188157459?thread_ts=1714057353.559839&cid=C036QM0SLJK & https://expensify.slack.com/archives/C036QM0SLJK/p1714091531288649?thread_ts=1713799261.297609&cid=C036QM0SLJK

Action Performed:

  1. Connect to QBO
  2. Go to Export
  3. Observe not all settings are selected by default
  4. Choose an export method for, say, company card export
  5. Observe the account selection is not selected

Expected Result:

  1. The following export settings should also be set by default when making a connection to QBO:

Export page

  • Preferred exporter = [policyOwner]
  • Date = Export date
  • Export out of pocket expenses as =
    • Export as = Vendor bill
    • Accounts payable = [first applicable account in the list is selected] Note: This select list appears to be completely blank right now, let's fix that
  • Export invoices as = [first applicable account in the list is selected]
  • Export company cards as =
    • Export as = Credit card
    • Account = [first applicable account in the list is selected]
  1. Then when choosing alternative export options, let's make sure the first applicable account in the list is selected as well:

"Export out of pocket expenses as" alt settings

  • Export as = Journal entry

  • Accounts payable = [first applicable account in the list is selected]

  • Export as = Check

  • Accounts payable = [first applicable account in the list is selected]

"Export company cards as" alt settings

  • Export as = Debit card

  • Account = [first applicable account in the list is selected]

  • Export as = Vendor bill

  • Accounts payable = [first applicable account in the list is selected]

  • Default vendor (if enabled, disabled by default)

    • Vendor = [first applicable account in the list is selected]
  1. Let's make sure we apply these changes on the "Advanced" page as well where applicable:
  • Sync reimbursed reports (setting should be toggled on by default) =
    • QuickBooks bill payment account = [first applicable account in the list is selected]
    • QuickBooks invoice collections account = [first applicable account in the list is selected]
  1. When someone changes a configuration setting (i.e updates exporting from Credit card to Vendor bill, make sure the value in the push input for the associated account selection is also updated along with the push label change. I.e
  • Export as = Credit card

  • Account = Amex Card Account

  • Export as = Vendor bill

  • Accounts payable = [first applicable account in the vendor list is selected]

Actual Result:

  1. Only the value in the Preferred exporter list looks to be selected by default on the export settings page
  2. When choosing an export method (i.e Credit Card) the first value in the sub-account that's revealed is not selected
  3. Sync reimbursed reports is not enabled by default on the Advanced page, and the two associated accounts with that setting aren't selected by default either
  4. Previously selected values are not cleared from the push input as the push label updates

Workaround:

Yes, they can select values and change values.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2024-04-26_01-51-56.mp4

View all open jobs on GitHub

CC: @hayata-suenaga @aldo-expensify @s77rt @teneeto @narefyev91 @zanyrenney

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions