[HOLD for payment 2024-06-13] [$500] Workspace - Not here page is briefly displayed when selecting a workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Sing up with a GMAIL new account
2. Create manual expense in Self DM
3. Create workspace
4. Navigate to the self DM
5. Click on 'Catgorize it' under the new expense
6. Select the new workspace

Expected Result:

Hmm its not here page shouldn't be displayed momentarily

Actual Result:

Hmmm it is not here page is displayed momentarily

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6461762_1714060426499.Screen_Recording_2024-04-25_at_6.51.36_in_the_evening.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b67f88414b7c0b94
• Upwork Job ID: 1783871746486759424
• Last Price Increase: 2024-06-18
• Automatic offers:
• ZhenjaHorbach | Contributor | 0

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Not here page is briefly displayed when selecting a workspace

What is the root cause of that problem?

The main problem with issue is that when we create workspace and then navigate to IOURequestStepCategory we need to wait when we get response from BE and only then we will get current categories using another request

App/src/libs/actions/Policy.ts

Lines 2566 to 2570 in 34434a5

	function openDraftWorkspaceRequest(policyID: string) {
	const params: OpenDraftWorkspaceRequestParams = {policyID};
	API.read(READ_COMMANDS.OPEN_DRAFT_WORKSPACE_REQUEST, params);
	}

What changes do you think we should make in order to solve the problem?

To fix this issue we can update IOURequestStepCategory and add Loader

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Lines 131 to 148 in 34434a5

	return (
	<StepScreenWrapper
	headerTitle={translate('common.category')}
	onBackButtonPress={navigateBack}
	shouldShowWrapper
	shouldShowNotFoundPage={shouldShowNotFoundPage}
	testID={IOURequestStepCategory.displayName}
	includeSafeAreaPaddingBottom={false}
	>
	<Text style={[styles.ph5, styles.pv3]}>{translate('iou.categorySelection')}</Text>
	<CategoryPicker
	selectedCategory={transactionCategory}
	policyID={report?.policyID ?? ''}
	onSubmit={updateCategory}
	/>
	</StepScreenWrapper>
	);
	}

For condition we can use similar logic from WorkspaceCategoriesPage (actually we have bug here and we need use null instead undefined because for this screen we are using useOnyx which return null instead undefined in case if we don't have value in Onyx ) (Alternatively we can add isLoading to Onyx as in my alternative proposition to make the behavior on these two screens the same )

const isLoading = !isOffline && policyCategories === undefined;

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 247 in 34434a5

const isLoading = !isOffline && policyCategories === undefined;

Also we can add similar component from 'WorkspaceCategoriesPage' for empty list of elements

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 305 to 311 in 34434a5

	{shouldShowEmptyState && (
	<WorkspaceEmptyStateSection
	title={translate('workspace.categories.emptyCategories.title')}
	icon={Illustrations.EmptyStateExpenses}
	subtitle={translate('workspace.categories.emptyCategories.subtitle')}
	/>
	)}

Using similar condition

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 249 in 34434a5

const shouldShowEmptyState = !categoryList.some((category) => category.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) && !isLoading;

OR just update text for not found component (But it depends on the design team)

What alternative solutions did you explore? (Optional)

As alternative we can add isLoader inside Onyx
And when we make a request we will use this value until we receive a response from the backend

App/src/libs/actions/Policy.ts

Lines 2566 to 2570 in 34434a5

	function openDraftWorkspaceRequest(policyID: string) {
	const params: OpenDraftWorkspaceRequestParams = {policyID};
	API.read(READ_COMMANDS.OPEN_DRAFT_WORKSPACE_REQUEST, params);
	}

We do something similar for openPolicyWorkflowsPage

App/src/libs/actions/Policy.ts

Line 2425 in 10fc359

function openPolicyWorkflowsPage(policyID: string) {

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b67f88414b7c0b94

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[sonialiap]

A polish issue that imo isn't super high value but since we already have a proposal, passing to external

[mananjadhav]

I think @ZhenjaHorbach's proposal looks good.

🎀 👀 🎀 C+ reviewed.