[HOLD for payment 2024-06-06] [$250] Details - Dropdown Menu Floats in Composer After Minimizing and Maximizing Website

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.65-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): abebemiherat@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Click on FAB > Start chat > Add email
2. Click on the header > Upload photo
3. Minimize the webpage > Click on the avatar to display the dropdown
4. Maximize the webpage. Notice that the dropdown menu floats in the composer

Expected Result:

The dropdown should align with the edit photo button and should not float in the composer

Actual Result:

The dropdown menu when editing the group photo floats in the composer after minimizing and maximizing the website

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6460696_1713987961614.rec.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01875ffa1608bd2090
• Upwork Job ID: 1783639833104637952
• Last Price Increase: 2024-05-14
• Automatic offers:
• DylanDylann | Reviewer | 0

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dropdown Menu Floats in Composer After Minimizing and Maximizing Website

What is the root cause of that problem?

We use measureInWindow from react-native to get the position of the anchor. There are lots of issues within measureInWindow with some browsers.

What changes do you think we should make in order to solve the problem?

As we do for HeaderView for the 3 dots menu

https://github.com/Expensify/App/blob/9e8d402403b710635de79b24627f033024b485c4/src/pages/home/HeaderView.tsx#L340-L341C45

We just need the windowWidth, because the 3 dots menu is always on the top right, we can use a style utility to define the position of the anchor.

The same for this issue here, we can replace this native measureInWindow by a style utility

App/src/components/AvatarWithImagePicker.tsx

Line 289 in 8383d80

anchorRef.current.measureInWindow((x, y, width, height) => {

- anchorPosition={popoverPosition}
+ anchorPosition={styles.popoverMenuOffset(windowWidth)}

By applying this method, we can utilize a styling utility to statically position the anchor based on the windowWidth, thereby avoiding the issues caused by measureInWindow. This change should ensure that the dropdown menu remains correctly positioned regardless of browser behavior during window resizing.

[jliexpensify]

I can repro this one, and I think it should be in #collect - #vsb is around chat functionality, and this is to do with settings.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01875ffa1608bd2090

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)