Onboarding - Onboarding modal doesn't get shown for expensifail accounts

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.65-0
Reproducible in staging?: y
Reproducible in production?: new feature
Issue found when executing PR: #39687
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Sign in with a new Expensifail account

Expected Result:

Onboarding modal shows up

Actual Result:

Onboarding modal doesn't show up for Expensifail accounts (Works fine for Gmail accounts)

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6460338_1713967391579.bandicam_2024-04-24_16-59-31-073.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[neil-marcellini]

Thanks!

[mountiny]

This is expected, the nvp is not set for domain controlled accounts