Repository navigation
[HOLD for payment 2024-06-03] [$250] Create automated tests for Workspace Profile, Members and Categories pages #40835
Description
Activity
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.- changed the title
[-]Create automated tests for Workspace Profile, Members and Categories pages[/-][+][$250] Create automated tests for Workspace Profile, Members and Categories pages[/+]on Apr 23, 2024 Job added to Upwork: https://www.upwork.com/jobs/~011452b1c44ee7036a
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (
External)Proposal
Please re-state the problem that we are trying to solve in this issue.
We need to add automated tests for new API commands in Workspace Profile, Members and Categories pages
What is the root cause of that problem?
This is new requirement, currently we don't have any automated tests for those commands
What changes do you think we should make in order to solve the problem?
For each command, we need to:
-
Define the test scenarios for the command, this will be the different cases that the input params of the command function (for example this) can take. Eg. If a param is optional, we need to test both scenarios where that params is, and is not provided. And there should be the scenarios for different user's use cases as well, we can check this by testing the flow in the UI to see what possible values/actions they can take that influence the command input.
-
Write unit tests with those scenarios, given a set of command function input, we need to check that
API.write/API.readare called with a correct set ofparametersandonyxData(eg. this call).
For how to write it, we'll write Jest tests just like we did for other utils like here
What alternative solutions did you explore? (Optional)
NA
-
@luacmartins I am concerned that those automation tests should be added to BE repository or this Expensify/App repository?
13 remaining items
Thanks @hoangzinh , seems like, with the deploy freezer, we're going to have a LOT of issue come due for payment at/around the same time
Reacted by Vinh Hoang- changed the title
[-][$250] Create automated tests for Workspace Profile, Members and Categories pages[/-][+][HOLD for payment 2024-06-03] [$250] Create automated tests for Workspace Profile, Members and Categories pages[/+]on May 27, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-03. 🎊
For reference, here are some details about the assignees on this issue:
- @hoangzinh requires payment automatic offer (Reviewer)
- @tienifr requires payment automatic offer (Contributor)
Contributor: @tienifr paid $250 via Upwork
Contributor+: @hoangzinh paid $250 via Upwork.I don't think we need a regression test here. @luacmartins , comment and reopen if you disagree.
No requession test needed
Problem
New API commands introduced as part of the Simplified Collect project don't have automated tests, which can lead to bugs and unexpected behavior when these commands are updated.
Solution
Add automated tests for the commands below:
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @mallenexpensify