Repository navigation
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Workspace switcher search bar is in the wrong place #40826
Description
Activity
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace switcher search bar is in the wrong place
What is the root cause of that problem?
We have included the everything section as a section of selection list.
App/src/pages/WorkspaceSwitcherPage/index.tsx
Lines 140 to 154 in 109d0f0
What changes do you think we should make in order to solve the problem?
We first need to remove the section from
SelectionListsections and create the jsx for everything section.pseudo-code:
<View style={[styles.mh4, styles.flexRow, styles.justifyContentBetween, styles.alignItemsCenter, styles.mb1]}> <Text style={styles.label} color={theme.textSupporting} > {translate('workspace.switcher.everythingSection')} </Text> </View> <View> <UserListItem item={{ text: CONST.WORKSPACE_SWITCHER.NAME, policyID: '', icons: [{source: Expensicons.ExpensifyAppIcon, name: CONST.WORKSPACE_SWITCHER.NAME, type: CONST.ICON_TYPE_AVATAR}], brickRoadIndicator: getIndicatorTypeForPolicy(undefined), isSelected: activeWorkspaceID === undefined, keyForList: CONST.WORKSPACE_SWITCHER.NAME, }} isFocused={false} isDisabled={false} showTooltip={false} canSelectMultiple={false} onSelectRow={() => selectPolicy({ text: CONST.WORKSPACE_SWITCHER.NAME, policyID: '', icons: [{source: Expensicons.ExpensifyAppIcon, name: CONST.WORKSPACE_SWITCHER.NAME, type: CONST.ICON_TYPE_AVATAR}], brickRoadIndicator: getIndicatorTypeForPolicy(undefined), isSelected: activeWorkspaceID === undefined, keyForList: CONST.WORKSPACE_SWITCHER.NAME, }) } /> </View>
This will be placed before the selection list. This is just pseudo-code, props are filled randomly. Minor styling changes can be discussed during PR phase.
What alternative solutions did you explore? (Optional)
remove_everything_Section.mp4
Job added to Upwork: https://www.upwork.com/jobs/~01f05cea763c8e597d
- changed the title
[-]Workspace switcher search bar is in the wrong place[/-][+][$250] Workspace switcher search bar is in the wrong place[/+]on Apr 23, 2024 Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (
External)Proposal
Please re-state the problem that we are trying to solve in this issue.
Search bar is below Choose workspace
What is the root cause of that problem?
This is a feature request
What changes do you think we should make in order to solve the problem?
- Pass the
BaseSelectionList's currentTextInputcomponent (wrapped inside a memoized variable) as a children of section'sCustomSectionHeader. Of course, we'll need to update the types accordingly:
App/src/components/SelectionList/BaseSelectionList.tsx
Lines 318 to 320 in 6b18ee9
<section.CustomSectionHeader section={section} > {textInput} </section.CustomSectionHeader>
- Inside
WorkspacesSectionHeader, render that children with proper style. InWorkspaceSwitcherPage:- Disable
shouldShowTopTextInput(new prop) to hide the current text input - Move
headerMessagetoWorkspacesSectionHeader(or we can wrap inside the above mentioned variable) - Use
iconLeftto display the magnifier icon and modifytextInputLabeltoFind a workspace.
- Disable
What alternative solutions did you explore? (Optional)
NA
- Pass the
Proposal Updated
- Added a note and result video
@gijoe0295 i don't like the idea of modifying BaseSelectionList just for this since it's used multiple places.
@Krishna2323 could you provide a more complete branch to test? there are some details you missed from the design.42 remaining items
@getusha , the job was created as a milestone in Upwork so it's been auto-paid. The hire date was before your cutoff date too, can you please rescind your offer request for payment via NewDot?
Contributor: @Krishna2323 paid $250 via Upwork
Contributor+: @getusha paid $250 via Upwork$250 approved for @getusha
@getusha , the job was created as a milestone in Upwork so it's been auto-paid. The hire date was before your cutoff date too, can you please rescind your offer request for payment via NewDot?
@mallenexpensify apologies for the delay, just refunded the amount on UW
I think we're good here now.
The hire date was before your cutoff date too, can you please rescind your offer request for payment via NewDot?
@getusha we need to pay via Upwork here because you were assigned here before 5/9, your eligible date. Can you please rescind your NewDot payment request and accept this new job I created? Thx
https://www.upwork.com/jobs/~01d662b6ac617b4224@getusha we need to pay via Upwork here because you were assigned here before 5/9, your eligible date. Can you please rescind your NewDot payment request and accept this new job I created? Thx
@mallenexpensify is there a way to refund the ND payment?
If you've already been paid via NewDot for this, let's not complicate things with a refund. Both you and I are assigned to this issue, I'll comment there that payment is already made and link to here (assuming it's $250). Also.. let's consider this an edge case, it should not be used as a reference in the future :)
Reacted by Getabalew Td'oh, looks like you haven't accepted the job in Upwork, can you plz @getusha ?
https://www.upwork.com/jobs/~01d662b6ac617b4224Paid, thanks @getusha
Payment confirmation is correct above
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
**Version Number:**v1.4.64-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Action Performed:
Break down in numbered steps
Expected Result:
Describe what you think should've happened
The search bar should be below the workspaces title
Actual Result:
Describe what actually happened
Search bar is below
Choose workspaceWorkaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @JmillsExpensify