[Hold for payment 2020-08-09] Pressing an arrow key while searching with no results will whitescreen the app

[rdjuric]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Search (CMD + K on mac OS)
2. Enter random characters in a way that you get no results
3. Press the down arrow, the up arrow or enter
4. Whitescreen

Expected Result:

Pressing an arrow key without any option to select shouldn't crash the app.

Actual Result:

The app crashes

Workaround:

Don't press arrow up or arrow down.

Platform:

Where is this issue occurring?

[x] Web
iOS
Android
[x] Desktop App
[x] Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

@amcheler ISSUE: On version v1.0.77-7 desktop, pressing an arrow key while searching with no results will whitescreen the app.

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[rdjuric]

Proposal

I think we can solve this by adding an early return here in case there're are no options to select/choose.
https://github.com/Expensify/Expensify.cash/blob/5a8eff84733e89edf0533554a550cf899e6cfa59/src/components/OptionsSelector.js#L116-L126

if (allOptions.length === 0) {
    return ;
}

[MelvinBot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Gonals]

Added weekly and firstpick tags! Sending to the pool!

[rdjuric]

@Gonals Do you think this one be worked by an External/contractor? 😃