Skip to content

[HOLD for payment 2024-08-02] [$250] Android - Not found page closes prematurely when navigating to invalid WS links #40509

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #36409
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open Android app
  2. Create a workspace
  3. Go to workspace settings page
  4. From another app deep link to any of these links:

Expected Result:

Not found view should be visible

Actual Result:

Not found view is seen for a second and then closes prematurely navigating to workspace settings page

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453817_1713455686115.Screen_Recording_20240418_184437_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bb3ea96da0ce5340
  • Upwork Job ID: 1781079172553498624
  • Last Price Increase: 2024-04-18
Issue OwnerCurrent Issue Owner: @twisterdotcom

Activity

  1. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Apr 18, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. kbecciv commented on Apr 18, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave-collect - Release 1

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 18, 2024
  5. changed the title [-]Android - Not found page closes prematurely when navigating to invalid WS links[/-] [+][$250] Android - Not found page closes prematurely when navigating to invalid WS links[/+] on Apr 18, 2024
  6. melvin-bot commented on Apr 18, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 18, 2024
  8. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

  9. neil-marcellini commented on Apr 18, 2024

    @neil-marcellini
    Contributor

    I was away for a little bit but I'll start looking more closely now

  10. neil-marcellini commented on Apr 18, 2024

    @neil-marcellini
    Contributor

    Let's see if reverting #36409 fixes the issue. I asked @fedirjh if he can test that since I'm busy with some backend stuff right now. I'll check back in 30 minutes.

  11. 25 remaining items

  12. twisterdotcom commented on May 22, 2024

    @twisterdotcom
    Contributor

    Payment Summary:

  13. added
    ReviewingHas a PR in review
    and removed on Jul 9, 2024
  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 26, 2024
  15. changed the title [-][$250] Android - Not found page closes prematurely when navigating to invalid WS links[/-] [+][HOLD for payment 2024-08-02] [$250] Android - Not found page closes prematurely when navigating to invalid WS links[/+] on Jul 26, 2024
  16. melvin-bot commented on Jul 26, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Jul 26, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-02. 🎊

    For reference, here are some details about the assignees on this issue:

    • @fedirjh requires payment through NewDot Manual Requests
  18. melvin-bot commented on Jul 26, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
    • [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@fedirjh] Determine if we should create a regression test for this bug.
    • [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions