You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-02] [$250] Android - Not found page closes prematurely when navigating to invalid WS links #40509
Version Number: 1.4.63-0 Reproducible in staging?: y Reproducible in production?: n Issue found when executing PR:#36409 Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Android - Not found page closes prematurely when navigating to invalid WS links[/-][+][$250] Android - Not found page closes prematurely when navigating to invalid WS links[/+]on Apr 18, 2024
Let's see if reverting #36409 fixes the issue. I asked @fedirjh if he can test that since I'm busy with some backend stuff right now. I'll check back in 30 minutes.
changed the title [-][$250] Android - Not found page closes prematurely when navigating to invalid WS links[/-][+][HOLD for payment 2024-08-02] [$250] Android - Not found page closes prematurely when navigating to invalid WS links[/+]on Jul 26, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Apr 18, 2024
Triggered auto assignment to @neil-marcellini (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 18, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
kbecciv commentedon Apr 18, 2024
We think that this bug might be related to #wave-collect - Release 1
[-]Android - Not found page closes prematurely when navigating to invalid WS links[/-][+][$250] Android - Not found page closes prematurely when navigating to invalid WS links[/+]melvin-bot commentedon Apr 18, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01bb3ea96da0ce5340
melvin-bot commentedon Apr 18, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)neil-marcellini commentedon Apr 18, 2024
I was away for a little bit but I'll start looking more closely now
neil-marcellini commentedon Apr 18, 2024
Let's see if reverting #36409 fixes the issue. I asked @fedirjh if he can test that since I'm busy with some backend stuff right now. I'll check back in 30 minutes.
25 remaining items
twisterdotcom commentedon May 22, 2024
Payment Summary:
[-][$250] Android - Not found page closes prematurely when navigating to invalid WS links[/-][+][HOLD for payment 2024-08-02] [$250] Android - Not found page closes prematurely when navigating to invalid WS links[/+]melvin-bot commentedon Jul 26, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 26, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 26, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: