[HOLD for payment 2024-06-06] [$250] RHP - User remains on the Private Notes page when clicked on back btn after reload

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Open https://staging.new.expensify.com/
2. Navigate to any conversation with other user
3. Click on Header to open Profile page
4. Click on Private Notes
5. Reload the page
6. Click on back button
7. Click on back button again

Expected Result:

User should be redirected to Profile page when clicked back button

Actual Result:

User remains on the Private Notes page when clicked on back button after page reload. When user clicked on back button again the RHP will be closed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6454034_1713463346120.Screen_Recording_2024-04-18_at_20.55.17.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f0ae1b806ad11050
• Upwork Job ID: 1781084747484880896
• Last Price Increase: 2024-04-18
• Automatic offers:
• shubham1206agra | Reviewer | 0
• nkdengineer | Contributor | 0

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

RHP closes when clicking on the back button in the private notes list page

What is the root cause of that problem?

we use the default navigation behaviour in the private notes list which dismisses the navigation if no route is found in the navigation history

App/src/pages/PrivateNotes/PrivateNotesListPage.tsx

Line 85 in 0140912

<HeaderWithBackButton

What changes do you think we should make in order to solve the problem?

since the back navigation for the private notes history is deterministic and always goes to the report details page then we can specify that behavior in the onBackButtonPress

                onBackButtonPress={() => ReportUtils.goBackToDetailsPage(report)}

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

RHP - User remains on the Private Notes page when clicked on back btn after reload

What is the root cause of that problem?

Here in the PRIVATE_NOTES_EDIT page we always go to PRIVATE_NOTES_LIST page using Navigation.goBack method by clicking back button. When we pass the fallbackRoute param in the Navigation.goBack method, it only goes to that route if the current route is the first one in the navigation stack, otherwise it goes back to the previous route. And so the current screen becomes first one in navigation stack, we navigate to the fallbackRoute after clicking the back button.

What changes do you think we should make in order to solve the problem?

1. Add ability to receive backTo param for ROUTES.PRIVATE_NOTES_EDIT.getRoute method. To do this update this line as below

getRoute: (reportID: string, accountID: string | number, backTo?: string) => getUrlWithBackToParam(`r/${reportID}/notes/${accountID}/edit` as const, backTo),

2. Add Navigation.getActiveRoute() as third ( backTo ) param in getRoute methods here and here

3. Update this line like below

onBackButtonPress={() => Navigation.goBack(route.params?.backTo)}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f0ae1b806ad11050

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[mallenexpensify]

Was able to repro, seems like it can be external, @shubham1206agra , can you review the bug and proposals above? Thx

2024-04-18_15-16-59.mp4