Skip to content

[HOLD for payment 2024-08-02] [$250] mweb-LHN-Mark as unread a message after deleting self mention displays green dot in LHN. #40469

Closed
Closed
[HOLD for payment 2024-08-02] [$250] mweb-LHN-Mark as unread a message after deleting self mention displays green dot in LHN.#40469
Assignees
twisterdotcomhungvu193neil-marcellinitienifr
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Description

@m-natarajan
m-natarajan
opened on Apr 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Open self DM report
  3. Mention self and send it
  4. Send another message
  5. Delete the previous DM message
  6. Navigate to LHN
  7. Long press the report in LHN and select mark as unread

Expected Result:

Mark as unread a message after deleting self mention must not display green dot in LHN.

Actual Result:

Mark as unread a message after deleting self mention displays green dot in LHN.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453516_1713452138014.self_email.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e421f5653f9e5c16
  • Upwork Job ID: 1783272895128035328
  • Last Price Increase: 2024-04-24
  • Automatic offers:
    • hungvu193 | Reviewer | 0
    • tienifr | Contributor | 0
Issue OwnerCurrent Issue Owner: @twisterdotcom

Activity

  1. m-natarajan
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 18, 2024
  2. melvin-bot
    assigned
    twisterdotcom
    on Apr 18, 2024

  3. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    melvin-botbot
    on Apr 18, 2024 – with Melvin Bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. m-natarajan commented on Apr 18, 2024

    @m-natarajan
    m-natarajan
    on Apr 18, 2024
    Author

    @twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  5. m-natarajan commented on Apr 18, 2024

    @m-natarajan
    m-natarajan
    on Apr 18, 2024
    Author

    We think this bug might be related to #vip-vsb

  6. twisterdotcom commented on Apr 19, 2024

    @twisterdotcom
    twisterdotcom
    on Apr 19, 2024
    Contributor

    A mobile web bug for an uncommon flow, this is niche.

  7. melvin-bot
    added
    Overdue
    on Apr 22, 2024

  8. melvin-bot commented on Apr 22, 2024

    @melvin-bot
    melvin-botbot
    on Apr 22, 2024 – with Melvin Bot

    @twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!

  9. melvin-bot commented on Apr 24, 2024

    @melvin-bot
    melvin-botbot
    on Apr 24, 2024 – with Melvin Bot

    @twisterdotcom Eep! 4 days overdue now. Issues have feelings too...

  10. twisterdotcom commented on Apr 24, 2024

    @twisterdotcom
    twisterdotcom
    on Apr 24, 2024
    Contributor

    Not just mweb:
    https://github.com/Expensify/App/assets/9133401/38e7564c-bcc8-4fcd-8a9a-db349a0e8ea2

  11. melvin-bot
    removed
    Overdue
    on Apr 24, 2024
  12. twisterdotcom
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 24, 2024
  13. melvin-bot
    changed the title [-]mweb-LHN-Mark as unread a message after deleting self mention displays green dot in LHN.[/-] [+][$250] mweb-LHN-Mark as unread a message after deleting self mention displays green dot in LHN.[/+] on Apr 24, 2024

  14. melvin-bot commented on Apr 24, 2024

    @melvin-bot
    melvin-botbot
    on Apr 24, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~01e421f5653f9e5c16

  15. 56 remaining items

  16. neil-marcellini commented on Jul 17, 2024

    @neil-marcellini
    neil-marcellini
    on Jul 17, 2024
    Contributor

    Turns out it's a backend bug though, and we already said above we're not going to fix that. Hopefully we can get this merged soon.

  17. neil-marcellini commented on Jul 23, 2024

    @neil-marcellini
    neil-marcellini
    on Jul 23, 2024
    Contributor

    The PR was merged today, finally!

  18. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    WeeklyKSv2
    on Jul 26, 2024
  19. melvin-bot
    changed the title [-][$250] mweb-LHN-Mark as unread a message after deleting self mention displays green dot in LHN.[/-] [+][HOLD for payment 2024-08-02] [$250] mweb-LHN-Mark as unread a message after deleting self mention displays green dot in LHN.[/+] on Jul 26, 2024

  20. melvin-bot commented on Jul 26, 2024

    @melvin-bot
    melvin-botbot
    on Jul 26, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-02. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hungvu193 requires payment through NewDot Manual Requests (Reviewer)
    • @tienifr requires payment through NewDot Manual Requests (Contributor)

  21. melvin-bot commented on Jul 26, 2024

    @melvin-bot
    melvin-botbot
    on Jul 26, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
    • [@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@hungvu193] Determine if we should create a regression test for this bug.
    • [@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  22. hungvu193 commented on Aug 1, 2024

    @hungvu193
    hungvu193
    on Aug 1, 2024
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: I can't really find the offending PR as this is an extremely edge case. See this comment.
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug: Yes

    Regression Test:

    1. Open App.
    2. Open self DM report.
    3. Mention yourself and send it.
    4. Send another message.
    5. Delete the previous DM message.
    6. Navigate to LHN.
    7. Long press the report in LHN and select mark as unread.
    8. Verify mark as unread a message after deleting self mention must not display green dot in LHN.

    Do we 👍 or 👎 ?

  23. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Aug 1, 2024

  24. twisterdotcom commented on Aug 2, 2024

    @twisterdotcom
    twisterdotcom
    on Aug 2, 2024
    Contributor

    Both eligible for Manual Requests. Payment Summary:

    • @hungvu193 paid $250 via NewDot Manual Request (Reviewer)
    • @tienifr paid $250 via NewDot Manual Request (Contributor)
  25. twisterdotcom
    closed this as completedon Aug 2, 2024

  26. JmillsExpensify commented on Aug 7, 2024

    @JmillsExpensify
    JmillsExpensify
    on Aug 7, 2024
    Contributor

    $250 approved for @hungvu193

  27. JmillsExpensify commented on Aug 14, 2024

    @JmillsExpensify
    JmillsExpensify
    on Aug 14, 2024
    Contributor

    $250 approved for @tienifr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions