Group - Offline added avatar is not showing with reduced opacity

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Crate a group chat
2. Navigate to the group chat
3. Apply offline mode
4. Click on chat header > click on upload avatar icon
5. Upload avatar

Expected Result:

Avatar should be grayed out

Actual Result:

Avatar is not grayed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6453314_1713426435179.offline_avatar.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@abekkala I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[nexarvo]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline added avatar is not grayed out

What is the root cause of that problem?

Right now we don't set pendingFields for group avatars that's why The pendingAction is null here:

App/src/components/AvatarWithImagePicker.tsx

Line 301 in 9b839f4

pendingAction={pendingAction}

We are not setting pendingFields in updateGroupChatAvatar

What changes do you think we should make in order to solve the problem?

We can set pendingFields in optimistic data here:

const optimisticData: OnyxUpdate[] = [
    {
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
        value: {
            avatarUrl: file?.uri ?? '',
+            pendingFields: {
+               avatar: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
+           },
        },
    },
];

Finally we will pass pendingActions below to be used in OfflineWithFeedback:

App/src/pages/ReportDetailsPage.tsx

Lines 231 to 247 in 9b839f4

	<AvatarWithImagePicker
	source={icons[0].source}
	isUsingDefaultAvatar={!report.avatarUrl}
	size={CONST.AVATAR_SIZE.XLARGE}
	avatarStyle={styles.avatarXLarge}
	shouldDisableViewPhoto
	onImageRemoved={() => {
	// Calling this without a file will remove the avatar
	Report.updateGroupChatAvatar(report.reportID ?? '');
	}}
	onImageSelected={(file) => Report.updateGroupChatAvatar(report.reportID ?? '', file)}
	editIcon={Expensicons.Camera}
	editIconStyle={styles.smallEditIconAccount}
	/>
	) : (
	<RoomHeaderAvatars
	icons={icons}

pendingAction={report?.pendingFields?.avatar ?? undefined}

What alternative solutions did you explore? (Optional)

[flodnv]

This is from #39757 @marcaaron 🙃