[Awaiting checklist completion][$250] LHN - HTML "<h1>" tag can be seen on the #admins room LHN preview

@allroundexperts

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.61.8
Reproducible in staging?: Y
Reproducible in production?: Y
Found when executing PR : https://github.com/Expensify/Expensify/issues/380529
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Log in with a new Gmail account
Create a workspace
Navigate to the LHN

Expected Result:

HTML tags shouldn't be visible.

Actual Result:

HTML "

" tag can be seen on the #admins room LHN preview. It's not visible in the room.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b3428578236ce20d
Upwork Job ID: 1780883160992833536
Last Price Increase: 2024-04-18
Automatic offers:

GandalfGwaihir | Contributor | 0

Issue Owner

Current Issue Owner: @allroundexperts

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@twisterdotcom

@twisterdotcom I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #collect project.

Pretty sure this is a dupe

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN option list content is not rendered properly and we see the html tags in report message

What is the root cause of that problem?

The API responds us HTML text when we receive OpenReport:

This is necessary because we render this HTML in main report screen, but we do not convert this to normal text when we display the message in LHN:

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Lines 217 to 225 in 1f694e2

    
           {optionItem.alternateText ? ( 
        
               <Text 
        
                   style={alternateTextStyle} 
        
                   numberOfLines={1} 
        
                   accessibilityLabel={translate('accessibilityHints.lastChatMessagePreview')} 
        
               > 
        
                   {optionItem.alternateText} 
        
               </Text> 
        
           ) : null}

This results in us seeing the content with HTML tags

What changes do you think we should make in order to solve the problem?

We need to convert this message to normal text first before being display, we can use htmlToText util from Expensify-common below:

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 223 in 1f694e2

{optionItem.alternateText}

{optionItem.alternateText ? (
                                        <Text
                                            style={alternateTextStyle}
                                            numberOfLines={1}
                                            accessibilityLabel={translate('accessibilityHints.lastChatMessagePreview')}
                                        >
                                            {parser.htmlToText(optionItem.alternateText)}
                                        </Text>
                                    ) : null}

We should also remove the styles.pre from alternateTextStyle as we no longer need paragraph whitespaces to be shows for the LHN text:

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Lines 61 to 63 in 1f694e2

    
           const alternateTextStyle = isInFocusMode 
        
               ? [textStyle, styles.optionAlternateText, styles.pre, styles.textLabelSupporting, styles.optionAlternateTextCompact, styles.ml2, style] 
        
               : [textStyle, styles.optionAlternateText, styles.pre, styles.textLabelSupporting, style];

Result

Result Video

Screen.Recording.2024-04-17.at.7.10.48.PM.mov

@twisterdotcom

Pretty sure this is a dupe

Can you please post the dupe if you find it, I will also search for it @twisterdotcom

Yes, sorry, being pulled into something else but will look again in a bit. I opened this tab, said that, searched and immediately got distracted, my bad.

haha, no worries

@twisterdotcom

No luck finding the dupe :), Are you sure that you saw this issue before @twisterdotcom ?

@puneetlath

So, here are the issues I think I was thinking about:

https://github.com/Expensify/Web-Expensify/pull/37784
#20590

Basically, I think that we show HTML in the LHN is expected, given @puneetlath closed the last issue I see for this above.

Going to get a C+ involved for their take too, because I agree this would be nice to clean up though if you can do it.

Job added to Upwork: https://www.upwork.com/jobs/~01b3428578236ce20d

@tylerkaraszewski

@tylerkaraszewski, @twisterdotcom, @allroundexperts, @GandalfGwaihir Eep! 4 days overdue now. Issues have feelings too...

melvin, I told you to go away.

@twisterdotcom

@twisterdotcom , can you pay this please :)

@allroundexperts

Thanks so much for the patience here folks. Always crazy coming back from a week out.

Payment Summary:

@allroundexperts paid $250 via NewDot Manual Requests (C+)
@GandalfGwaihir paid $250 here (Contributor)

@allroundexperts

@allroundexperts we just need the regression steps here.

Checklist

I was not able to find the exact PR. I think that something changed on the backend which caused this.
N/A
N/A
A regression test would be helpful. The test steps given in the OP look good enough to me.

@allroundexperts

$250 approved for @allroundexperts

Navigation Menu

Repository navigation

[Awaiting checklist completion][$250] LHN - HTML "<h1>" tag can be seen on the #admins room LHN preview #40348

Action Performed:

Expected Result:

Actual Result:

" tag can be seen on the #admins room LHN preview. It's not visible in the room.

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

36 remaining items

Checklist

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	{optionItem.alternateText ? (
	<Text
	style={alternateTextStyle}
	numberOfLines={1}
	accessibilityLabel={translate('accessibilityHints.lastChatMessagePreview')}
	>
	{optionItem.alternateText}
	</Text>
	) : null}

	const alternateTextStyle = isInFocusMode
	? [textStyle, styles.optionAlternateText, styles.pre, styles.textLabelSupporting, styles.optionAlternateTextCompact, styles.ml2, style]
	: [textStyle, styles.optionAlternateText, styles.pre, styles.textLabelSupporting, style];

[Awaiting checklist completion][$250] LHN - HTML "<h1>" tag can be seen on the #admins room LHN preview #40348

Description

Action Performed:

Expected Result:

Actual Result:

" tag can be seen on the #admins room LHN preview. It's not visible in the room.

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Apr 17, 2024

izarutskaya commented on Apr 17, 2024

izarutskaya commented on Apr 17, 2024

twisterdotcom commented on Apr 17, 2024

allgandalf commented on Apr 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

allgandalf commented on Apr 17, 2024

twisterdotcom commented on Apr 17, 2024

allgandalf commented on Apr 17, 2024

allgandalf commented on Apr 18, 2024

twisterdotcom commented on Apr 18, 2024

melvin-bot commented on Apr 18, 2024

36 remaining items

melvin-bot commented on May 13, 2024

tylerkaraszewski commented on May 13, 2024

allgandalf commented on May 14, 2024

twisterdotcom commented on May 14, 2024

twisterdotcom commented on May 14, 2024

allroundexperts commented on May 14, 2024

Checklist

JmillsExpensify commented on Jun 28, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions