[HOLD for payment 2024-06-06] [$250] Implement offline behavior and error handling for `UpdateGroupChatName`

[marcaaron]

Similar to #39983

We are now able to add a custom Group chat name. However, we do not handle any failure case yet.

Let's take whatever we are doing for the update "workspace room" name flow and apply the same error handling here.

In the backend, we currently send exceptions like this:

Onyx::handleException($e, 'AD9240FD-A780-425D-B98D-96DD6E4251C1', OnyxKeys::COLLECTION_REPORT.$reportID, ['errorFields', 'reportName']);

Which will put an error field on the report if updating the name fails.

We need that error to lead the user back to the "Settings" > "Name" field (RBR) and display an error message back to the user.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0128ec154dad5b4df3
• Upwork Job ID: 1786226453820362752
• Last Price Increase: 2024-05-03
• Automatic offers:
• dukenv0307 | Reviewer | 0
• nkdengineer | Contributor | 0

Issue Owner

Current Issue Owner: @jliexpensify

[s77rt]

Cases to check (not limited to):

1. The value that we validate vs. the value that we send to the BE are different (one is trimmed the other is not)
2. Is the limit 255 or 256 (isValidReportName uses 255 while maxLength uses 256)
3. See if we can remove isValidReportName function (maxLength prop should be enough)
4. Clear error after trying to set a new name

Screen.Recording.2024-04-11.at.8.47.27.AM.mov

[marcaaron]

This can come off HOLD now

[marcaaron]

On looking some more I am not sure if we need any BE change for this. This is the only check we have that might throw...

So, in reality the BE is more restrictive than the frontend atm. But I think that is fine.

Let's just update the frontend and make sure we handle any possible error (though I'm not sure what that would be really besides user losing access to the report - and that is quite rare).

[melvin-bot]

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️