Repository navigation
[$250] Wallet - After adding Debit Card user is directed to /home url and white blank page #39929
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4480375
Issue reported by: Applause - Internal Team
Action Performed:
Prerequisite: A bank account is added previously
- Log in with a expensifail account
- Navigate to Settings; Wallet
- Click on "Add bank account"
- Click on the "Debit Card" option
- Enter any debit card number from this list Sandbox Cards
- For the rest of the fields you enter any random valid data
- Click on Save
- Click Back arrow on Additional Details
Expected Result:
User is directed to the url "https://staging.new.expensify.com/settings/wallet"
and see the wallet page
Actual Result:
User is directed to the url "https://staging.new.expensify.com/home"
instead of "https://staging.new.expensify.com/settings/wallet"
and see a blank white page after blinking a milisecond wallet page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6442636_1712599812072.2024-04-08_20-41-45.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01b1f26018d8ecba15
- Upwork Job ID: 1778889569395892224
- Last Price Increase: 2024-04-12
- Automatic offers:
- dukenv0307 | Reviewer | 0
- bernhardoj | Contributor | 0
Activity
melvin-bot commentedon Apr 9, 2024
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.lanitochka17 commentedon Apr 9, 2024
@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
bernhardoj commentedon Apr 9, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
After adding a debit card, the user is shown a LHN with an empty/blank central page screen.
What is the root cause of that problem?
After adding a debit card page, we call
PaymentMethods.continueSetup()App/src/pages/settings/Wallet/AddDebitCardPage.tsx
Line 82 in 8e7575a
In
PaymentMethods.continueSetup(), we callNavigation.goBackwith a fallback route and the fallback route value is defaulted toROUTES.HOME.ROUTES.HOMErefers to the LHN.App/src/libs/actions/PaymentMethods.ts
Lines 33 to 35 in efa7d16
Because the add debit card page is the only RHP page, the fallback route will be used, so the add debit card page is replaced with
ROUTES.HOME, that's why we see the LHN with an empty/blank central page screen.What changes do you think we should make in order to solve the problem?
We should remove the default fallback route and make it optional.
App/src/libs/actions/PaymentMethods.ts
Line 33 in efa7d16
This way, after adding a debit card page, the page behind the RHP will still be the settings page.
This is consistent with what we did in this PR which is removing ROUTES.HOME from fallback route.
melvin-bot commentedon Apr 12, 2024
@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-] Wallet - After adding Debit Card user is directed to /home url and white blank page[/-][+][$250] Wallet - After adding Debit Card user is directed to /home url and white blank page[/+]melvin-bot commentedon Apr 12, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01b1f26018d8ecba15
melvin-bot commentedon Apr 12, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (
External)15 remaining items
melvin-bot commentedon May 10, 2024
This issue has not been updated in over 15 days. @johncschuster, @bernhardoj, @hayata-suenaga, @dukenv0307 eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
hayata-suenaga commentedon May 10, 2024
The PR was deployed to production three weeks ago. I don't know why Melvin didn't remove the reviewing label.
johncschuster commentedon May 13, 2024
Oh wow, thanks for calling that out, @hayata-suenaga. I'll get payment taken care of now.
johncschuster commentedon May 13, 2024
I've issued payment 🎉 . Thanks for your patience, everyone!
hayata-suenaga commentedon May 13, 2024
closing the issue now. Please feel free to re-open the issue if the payments haven't received 😄